From owner-p4-projects@FreeBSD.ORG Tue Jul 29 17:24:32 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id D39FA106567E; Tue, 29 Jul 2008 17:24:32 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 978E91065674 for ; Tue, 29 Jul 2008 17:24:32 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id 4DDAD8FC23 for ; Tue, 29 Jul 2008 17:24:32 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id D481F14D66F6; Tue, 29 Jul 2008 19:09:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.mypc.hu ([127.0.0.1]) by localhost (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BOERvM667vTr; Tue, 29 Jul 2008 19:09:17 +0200 (CEST) Received: from [192.168.2.177] (catv-50629c59.catv.broadband.hu [80.98.156.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id 9ADF014D66F1; Tue, 29 Jul 2008 19:09:17 +0200 (CEST) Message-ID: <488F4EB8.5010308@FreeBSD.org> Date: Tue, 29 Jul 2008 19:09:12 +0200 From: =?ISO-8859-1?Q?G=E1bor_K=F6vesd=E1n?= User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Kris Kennaway References: <200807291601.m6TG1FXh039193@repoman.freebsd.org> <488F4B1A.3000207@FreeBSD.org> In-Reply-To: <488F4B1A.3000207@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: Perforce Change Reviews , Max Khon Subject: Re: PERFORCE change 146209 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jul 2008 17:24:33 -0000 Kris Kennaway escribió: > Gabor Kovesdan wrote: >> http://perforce.freebsd.org/chv.cgi?CH=146209 >> >> Change 146209 by gabor@gabor_server on 2008/07/29 16:01:05 >> >> - Just handle some command line options as noop. They seem to be >> rarely used based on the resources describing them. From now on >> let's concentrate on the really practical features instead of >> these ones. > > I don't think it's a good idea to "implement" options as NOPs unless > they really are NOPs. This will just cause silent failure and/or > script misbehaviour, which may be very hard to track down. I've been also thinking of this, and I'm still a bit unsure. It would be bad if scripts failed due to this, but it would be also bad if scripts didn't run because of a e.g. --side-by-side argument, which rarely (or never?) makes any difference. I've played with the options a bit and a lot of them made no difference in the output neither with normal diff nor with context diff nor with unified diff. Maybe the best way to investigate what are they for would be to dig deeply in the GNU code, which is a mess. I haven't even found info about them on Google, thus I don't think they worth the effort. My mentor added to CC. Best, -- Gabor Kovesdan EMAIL: gabor@FreeBSD.org WWW: http://www.kovesdan.org