From owner-freebsd-hackers Wed Mar 6 10:13:37 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 1111D37B400; Wed, 6 Mar 2002 10:13:36 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g26ID8Y01371; Wed, 6 Mar 2002 10:13:08 -0800 (PST) (envelope-from obrien) Date: Wed, 6 Mar 2002 10:09:18 -0800 From: "David O'Brien" To: Poul-Henning Kamp Cc: Mike Meyer , Mike Meyer , Giorgos Keramidas , hackers@FreeBSD.ORG Subject: Re: RFC: style(9) isn't explicit about booleans for testing. Message-ID: <20020306100918.A1093@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <15493.61384.557931.883967@guru.mired.org> <30203.1015411062@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <30203.1015411062@critter.freebsd.dk>; from phk@critter.freebsd.dk on Wed, Mar 06, 2002 at 11:37:42AM +0100 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Mar 06, 2002 at 11:37:42AM +0100, Poul-Henning Kamp wrote: > Ahh, but here you hit one of my pet-peeves. I hate assignments inside > conditionals. I prefer the above written as: It does not matter. Style(9) does not [intentionally] avoid PHK's pet peeves. It documents the style used by the CSRG with some modernizations. All this "IMO" does not matter as much as showing actual code examples from /sys. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message