Date: Sun, 06 Nov 2011 16:13:04 -0800 From: Xin LI <delphij@delphij.net> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-rc@FreeBSD.ORG, d@delphij.net, Eygene Ryabinkin <rea@FreeBSD.ORG> Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface Message-ID: <4EB72290.8030104@delphij.net> In-Reply-To: <4EB71580.20507@FreeBSD.org> References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/06/11 15:17, Doug Barton wrote: > On 11/06/2011 03:02, Xin LI wrote: >> Hi, >> >> It seems that 226879 have introduced an error indication where if >> an interface is up and is not set to DHCP, the devd invoked >> /etc/rc.d/dhclient wlan0 call would generate an annoying >> message. >> >> I think this message is not necessary at all -- normally >> /etc/rc.d/dhclient is used by the system and it's just legitimate >> that a network interface comes up and have not assigned as DHCP. >> >> I'd like to propose the attached change, which turns this message >> into debug message but keep the exit intact. >> >> Comments? > > What harm is the error message causing? It seems useful to me to > know if something is happening in the background that may need the > administrator's attention. It's harmful because it's not an error -- for example, a bge0 interface which is a member of lagg group, is usually marked explicitly as non-DHCP. On the other hand, can you give me an example where it *is* an error? :-) I can't seem to think about one but I could be wrong here. It sounds like to me a POLA violation by the way since it's not the way it was, but my argument is primarily about "this gives an error message for valid configuration" and not about POLA. Cheers, - -- Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJOtyKQAAoJEATO+BI/yjfBNksH/RavqeOnpVsVVhu/aGeotU5c c8qQ+PhsO8rXPPOdaET4XBHKkZNNHcX3/BaPe/zUDHDoCVT9S21RrT3SYzANC8J6 gWbi6xwXN2qFOaYEy0Uj0JO4zilMarpMgSW+67V+C3fwVX75yP9q6FOANRqORdlS HgSVepF+CAXOhva7T95CD7SA/S6PADw7xfnDoleHjjw/m/nH+O0AoW3/It7hMEPe tq1yj8MxiRv/WQJBg7zaEao9cEooJrKBoq7P8v/jmiuoYSw/XptwBsrvqyhSqgeq qDzyOMG3+XUd26lMnSbu9BF2vP+B4qq46+SNGFihv4YTb8bodJcm8OJOlQ25fgc= =0udw -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EB72290.8030104>