From owner-freebsd-current@FreeBSD.ORG Fri Mar 12 19:10:55 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1AD51065672 for ; Fri, 12 Mar 2010 19:10:55 +0000 (UTC) (envelope-from julian@elischer.org) Received: from out-0.mx.aerioconnect.net (outq.internet-mail-service.net [216.240.47.240]) by mx1.freebsd.org (Postfix) with ESMTP id C178F8FC1B for ; Fri, 12 Mar 2010 19:10:55 +0000 (UTC) Received: from idiom.com (postfix@mx0.idiom.com [216.240.32.160]) by out-0.mx.aerioconnect.net (8.13.8/8.13.8) with ESMTP id o2CJAs9F010514; Fri, 12 Mar 2010 11:10:54 -0800 X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137]) by idiom.com (Postfix) with ESMTP id D48112D6011; Fri, 12 Mar 2010 11:10:53 -0800 (PST) Message-ID: <4B9A91BC.5050203@elischer.org> Date: Fri, 12 Mar 2010 11:10:52 -0800 From: Julian Elischer User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Gary Jennejohn , Garrett Cooper , freebsd-current@freebsd.org References: <4B991C00.3010809@intertainservices.com> <790a9fff1003111714s58d9ee4bl6454d1d52bf705b8@mail.gmail.com> <7d6fde3d1003111720g7dccf93w1f51db88758a5c4d@mail.gmail.com> <20100311.192423.683591382013853731.imp@bsdimp.com> <7d6fde3d1003112024o646afbf2w1ee4d81abae7e608@mail.gmail.com> <20100312113625.1b2b017f@ernst.jennejohn.org> <20100312110221.GC99813@acme.spoerlein.net> In-Reply-To: <20100312110221.GC99813@acme.spoerlein.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.67 on 216.240.47.51 Cc: Subject: Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2010 19:10:56 -0000 Ulrich Spörlein wrote: > On Fri, 12.03.2010 at 11:36:25 +0100, Gary Jennejohn wrote: >> On Thu, 11 Mar 2010 20:24:57 -0800 >> Garrett Cooper wrote: >> >>> I can haz PR review then? Here's an easy one :)... >>> >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=144644 >>> >> Looks OK to me except I don't like the >> if (something) { >> one-line-of-code(); >> } >> constructs, but according to style(9) these are sort-of OK, viz >> >> Closing and opening braces go on the same line as the else. Braces that >> are not necessary may be left out. >> ^^^^^^^^^^^^^^^ >> if (test) >> stmt; >> else if (bar) { >> stmt; >> stmt; >> } else >> stmt; >> >> Saved by the "may." > > True, but some folks (me included) really hate it, when different > bracing is used *within* the same statement. The example above really is > horrible. If one if/else-if clause needs braces, just brace them all. This > loses no vertical space (the dangling else excluded) and some folks find > it visually more pleasing/easier to read. > > ... hence begins the bikeshedding. "Green" My personal preference is that if one clause requires braces, they all get them so you would never see "else {" or "} else" just "else" or "} else {" I just find it helps keep everything correctly associated when reading. > > Bye, > Uli > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"