From owner-svn-ports-head@FreeBSD.ORG Tue Nov 27 15:54:33 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 785D3772 for ; Tue, 27 Nov 2012 15:54:33 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id DC78B8FC1F for ; Tue, 27 Nov 2012 15:54:32 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id j13so12016616lah.13 for ; Tue, 27 Nov 2012 07:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=NeFVXx2EIhVfSSBOKjpmBYsCodQhYZO43a4z/UTRG5A=; b=eg+eaEL6ok10glAf1gqe0j7SLfnGBCusZUe21DgIlmj9qwirzwCqh4i1X7cLOUouEw ghsfTuUEpHV/DTzV9r9cO+i1TESds6b160YYCN1LpXl9i79vkcpCPFa9Vct5LFRTnAhj yPkG1RX8anWDq1s08vv3lb1fxglI4FwfHrpPE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=NeFVXx2EIhVfSSBOKjpmBYsCodQhYZO43a4z/UTRG5A=; b=QcqzpYabFYtnB9cSMpnwbumPKEXepU8PC57gf9FCDhiD8LrR4fOtV6Ug9b11RT/dFp GtnUlZJ2yQrjMgIyZQa3x9cafvjQ/4len4SzsdFC3ZQsjyvwE8up04Cg82XZBTueAqlo RfIcZHbnEawNdhwYJjj/n/9nFnpeT3XWHaRRuayh22Ev9Box+S7DcE2MxEQf+3u4cN6S iqjvUy/Gdp3n77sRUGy0ViaYEow6ukrFsB7udtWgV7K5m+vG9NQcU67RLCB8e5x0YBOL UoqbD2FnXNoAm9s/LSlgtGswTnz0FGKeqDkJ1NVFxn/fbUCkvyJZrnhpkCZnWyRGxvMg 1jMA== Received: by 10.152.103.100 with SMTP id fv4mr14820400lab.39.1354031671291; Tue, 27 Nov 2012 07:54:31 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Tue, 27 Nov 2012 07:54:00 -0800 (PST) In-Reply-To: <20121127155046.GA72381@FreeBSD.org> References: <201211271205.qARC54XQ060171@svn.freebsd.org> <20121127125610.GA59490@FreeBSD.org> <20121127133107.GA740@ravenloft.kiev.ua> <20121127135846.GA63249@FreeBSD.org> <20121127151842.GA5768@ravenloft.kiev.ua> <20121127155046.GA72381@FreeBSD.org> From: Eitan Adler Date: Tue, 27 Nov 2012 10:54:00 -0500 X-Google-Sender-Auth: imNaHbC6g-pZTMYgbnoUSs7z2ZM Message-ID: Subject: Re: svn commit: r307837 - head/comms/morse To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQn6r7hc5w5tYFhOEvVgfld6tN5czDPO2nmE1UkVLGcUkOVcbOypDcX3VCZcBqT5Zr/VkXDi Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Alex Kozlov X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2012 15:54:33 -0000 On 27 November 2012 10:50, Alexey Dokuchaev wrote: > On Tue, Nov 27, 2012 at 05:18:42PM +0200, Alex Kozlov wrote: >> On Tue, Nov 27, 2012 at 01:58:46PM +0000, Alexey Dokuchaev wrote: >> > On Tue, Nov 27, 2012 at 03:31:07PM +0200, Alex Kozlov wrote: >> > > I suppose I can change PA_DESC to PULSEAUDIO_DESC, but it's not really >> > > matter, because in this case specific descriptions are better and I'm not >> > > going to use generic ones from bsd.options.desc.mk. >> > >> > Yes, that was my point: use standard names, adjust default descriptions if >> > you feel that they are too generic for this particular case. >> >> Fine, I will ask maintainer if he wants to change description name >> for an aesthetic purposes. It would be minor POLA violation though, >> some users may have already set PA in make.conf. > > It is not just a matter of aesthetics, it's reducing environment pollution > with gratuitously different names of standard knobs. As for POLA, these > days people are supposed to cache their OPTIONS selection in /var/db/ports > instead of hardcoding them in /etc/make.conf. Upon upgrade, dialog will > pop up again since OPTIONS had changed, nothing should go unnoticed here. Some people do not want to use the dialog(1) interface. Using /etc/make.conf is expected and fully supported. We should not gratuitously break option names. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams