From owner-svn-src-all@freebsd.org Mon Apr 22 08:32:44 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7E8815932B7; Mon, 22 Apr 2019 08:32:44 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 442928041B; Mon, 22 Apr 2019 08:32:44 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [176.74.212.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id AE6892601C2; Mon, 22 Apr 2019 10:32:41 +0200 (CEST) Subject: Re: svn commit: r346530 - in head/sys: netinet netinet6 From: Hans Petter Selasky To: Enji Cooper Cc: src-committers , svn-src-all , svn-src-head@freebsd.org References: <201904220727.x3M7ROpR009729@repo.freebsd.org> <2F3D6B17-AF4F-4B0F-B20E-5EF41DE851F9@gmail.com> <87917500-0381-79d8-a34b-819848abed32@selasky.org> Message-ID: Date: Mon, 22 Apr 2019 10:32:13 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87917500-0381-79d8-a34b-819848abed32@selasky.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 442928041B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.960,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 08:32:44 -0000 On 4/22/19 10:10 AM, Hans Petter Selasky wrote: > On 4/22/19 9:52 AM, Enji Cooper wrote: >> >>> On Apr 22, 2019, at 12:27 AM, Hans Petter Selasky >>> wrote: >>> >>> Author: hselasky >>> Date: Mon Apr 22 07:27:24 2019 >>> New Revision: 346530 >>> URL: https://svnweb.freebsd.org/changeset/base/346530 >>> >>> Log: >>>   Fix panic in network stack due to memory use after free in relation to >>>   fragmented packets. >>> >>>   When sending IPv4 and IPv6 fragmented packets and a fragment is lost, >>>   the mbuf making up the fragment will remain in the temporary hashed >>>   fragment list for a while. If the network interface departs before the >>>   so-called slow timeout clears the packet, the fragment causes a panic >>>   when the timeout kicks in due to accessing a freed network interface >>>   structure. >>> >>>   Make sure that when a network device is departing, all hashed IPv4 and >>>   IPv6 fragments belonging to it, get freed. >>> >>>   Backtrace: >>>   panic() >>>   icmp6_reflect() >>> >>>   hlim = ND_IFINFO(m->m_pkthdr.rcvif)->chlim; >>>   ^^^^ rcvif->if_afdata[AF_INET6] is NULL. >>> >>>   icmp6_error() >>>   frag6_freef() >>>   frag6_slowtimo() >>>   pfslowtimo() >>>   softclock_call_cc() >>>   softclock() >>>   ithread_loop() >>> >>>   Differential Revision:    https://reviews.freebsd.org/D19622 >>>   Reviewed by:        bz (network), adrian >>>   MFC after:        1 week >>>   Sponsored by:        Mellanox Technologies >> >> This commit broke the build on mips, etc: >> >> 07:36:06 >> --- ip_reass.o --- >> >> 07:36:06 >> /usr/src/sys/netinet/ip_reass.c:641: error: expected ')' before '(' token >> >> 07:36:06 *** [ip_reass.o] Error code 1 >> >> EVENTHANDLER_DEFINE looks like it doesn’t work with gcc? > > I'm looking into it. > > Thank you! > > --HPS > > > Should be fixed by r346535 Else I'll revert. --HPS