From owner-freebsd-standards  Mon Sep 23  6:45:33 2002
Delivered-To: freebsd-standards@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B1F8837B401; Mon, 23 Sep 2002 06:45:32 -0700 (PDT)
Received: from smtp02.iprimus.net.au (smtp02.iprimus.net.au [210.50.76.70])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D296143E65; Mon, 23 Sep 2002 06:45:31 -0700 (PDT)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from dilbert.robbins.dropbear.id.au ([210.50.81.159]) by smtp02.iprimus.net.au with Microsoft SMTPSVC(5.0.2195.4617);
	 Mon, 23 Sep 2002 23:45:29 +1000
Received: from dilbert.robbins.dropbear.id.au (irdmttc5mx3dpfl8@localhost [127.0.0.1])
	by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6) with ESMTP id g8NDjQCj027636;
	Mon, 23 Sep 2002 23:45:27 +1000 (EST)
	(envelope-from tim@dilbert.robbins.dropbear.id.au)
Received: (from tim@localhost)
	by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6/Submit) id g8NDjNhL027635;
	Mon, 23 Sep 2002 23:45:23 +1000 (EST)
	(envelope-from tim)
Date: Mon, 23 Sep 2002 23:45:23 +1000
From: Tim Robbins <tjr@FreeBSD.org>
To: Mike Barcroft <mike@FreeBSD.org>
Cc: standards@FreeBSD.org, Josef Karthauser <joe@tao.org.uk>
Subject: Re: select.diff for review
Message-ID: <20020923234523.A27512@dilbert.robbins.dropbear.id.au>
References: <20020922235943.G91924@espresso.q9media.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20020922235943.G91924@espresso.q9media.com>; from mike@FreeBSD.org on Sun, Sep 22, 2002 at 11:59:43PM -0400
X-OriginalArrivalTime: 23 Sep 2002 13:45:30.0527 (UTC) FILETIME=[7B5AE2F0:01C26307]
Sender: owner-freebsd-standards@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-standards.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-standards>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-standards>
X-Loop: FreeBSD.ORG

On Sun, Sep 22, 2002 at 11:59:43PM -0400, Mike Barcroft wrote:

> Attached is a patch which makes <sys/select.h> much more conformant by
> bringing over components from <sys/types.h>.  Comments appreciated.
[...]

> Index: include/unistd.h
[...]
> +#if __BSD_VISIBLE
> +#ifndef _SELECT_DECLARED
> +#define	_SELECT_DECLARED
>  int	 select(int, fd_set *, fd_set *, fd_set *, struct timeval *);
> +#endif
> +#endif

I think it's probably better if you don't test whether select() has been
declared, and simply declare it anyway. If the two prototypes get out of
sync with each other, the compiler will warn, otherwise it's harmless.


Tim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message