From owner-svn-src-all@FreeBSD.ORG Tue Nov 11 17:14:06 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 649AA7C5; Tue, 11 Nov 2014 17:14:06 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3B64AB56; Tue, 11 Nov 2014 17:14:06 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id CC737B93B; Tue, 11 Nov 2014 12:14:02 -0500 (EST) From: John Baldwin To: Andrey Chernov Subject: Re: svn commit: r274365 - head/contrib/tzcode/stdtime Date: Tue, 11 Nov 2014 11:34:52 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <201411110407.sAB47gBT003976@svn.freebsd.org> <920BE50C-2DBA-4DCE-BFAB-ACFC11C5A09E@gmail.com> <54623400.1080407@freebsd.org> In-Reply-To: <54623400.1080407@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Message-Id: <201411111134.52984.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 11 Nov 2014 12:14:02 -0500 (EST) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Garrett Cooper , Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2014 17:14:06 -0000 On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: > On 11.11.2014 18:34, Garrett Cooper wrote: > >> This code is wrong in any case, setting EOVERFLOW even in unneeded > >> no-error cases like breaking from the loop. See how NetBSD does it > >> correctly instead. > > > > Hi! > > I saw your reply earlier but hadn't gotten an opportunity to revise the patch like you suggested. I'll look at the NetBSD code and see if I can adapt it to our copy of tzcode. > > Thank you! > > > > Currently as we need only EOVERFLOW parts from it, I don't think it will > be hard task to merge only them. Do you know if it is fixed upstream? I want to import newer tzcode from upstream to get implementations of the extensions to allow use of arbitrary time zones (mktime_z, etc.) -- John Baldwin