From owner-freebsd-current@FreeBSD.ORG Wed Jul 9 09:08:35 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 312C537B404; Wed, 9 Jul 2003 09:08:35 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC43943FA3; Wed, 9 Jul 2003 09:08:32 -0700 (PDT) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 98B662ED40D; Wed, 9 Jul 2003 09:08:32 -0700 (PDT) Date: Wed, 9 Jul 2003 18:08:32 +0200 From: Maxime Henrion To: Mark Murray Message-ID: <20030709160832.GH42121@elvis.mu.org> References: <20030709154006.GG42121@elvis.mu.org> <200307091550.h69FoubN081076@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307091550.h69FoubN081076@grimreaper.grondar.org> User-Agent: Mutt/1.4.1i cc: Warner Losh cc: current@freebsd.org Subject: Re: Broken ep0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jul 2003 16:08:35 -0000 Mark Murray wrote: > Maxime Henrion writes: > > > Can you have a look at this please? > > > > > > The symptoms are an ep0 that works for a few packets and then > > > completely stops working. It doesn't respond to pings, nothing. > > > > I think you and/or Warner got mistaken. My last round of changes > > to if_ep.c _fixed_ some race conditions that previously weren't a > > problem, but became a problem once Warner flag'd the pccbb interrupts > > INTR_MPSAFE. It's very possible that there are other problems left > > in the ep(4) driver, but I highly doubt my changes to if_ep.c are the > > culprit. I'm sorry but I can't do anything for you since I don't > > even have ep(4) hardware here ; I was able to fix the race conditions > > mentioned above because people reported panics with stacktrace that > > made the problem obvious. > > OK - problem. > > I have a broken driver, with a dodgy patch to "fix" it, and you guys are > both saying "not my problem". You should mention that the dodgy patch to "fix" this is to backout _Warner_'s commit, not mine. I think it's a sufficient proof that I have nothing to do with this, and I'm quite amazed to hear that Warner thinks my commits are the culprit. He didn't even talk to me about this, are you sure you didn't get mistaken? > I'm quite happy to make it my problem, but I'll need a bit of help, > please. Who is it going to be? As I said, I'd be happy to help you, but it's hard when I don't even have the hardware to test with... Cheers, Maxime