From nobody Wed Oct 5 01:16:54 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MhxW61412z4f8Ty; Wed, 5 Oct 2022 01:17:06 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MhxW60ZFnz3YgK; Wed, 5 Oct 2022 01:17:06 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-pj1-f48.google.com with SMTP id 8-20020a17090a0b8800b00205d8564b11so415773pjr.5; Tue, 04 Oct 2022 18:17:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=8fKIQjkNTMJ2Uk8eft3uQlxyPxc4LNhSFxOidjuRRcs=; b=r85uSEdOZxrKq9LlVLDiCtYk8/y47HNh3nlrYwisnaiReTlv13aLpKoO9yrrwnacsN 1oFhgfpI1b0RQv2MdoYK1W7cAiIzVzcg3T81aN+tF9YBGVlg88E4IiKiM41Uo8Mo/5Gz HJKGt2LFDZXlAf7f1y4Ai72OEkWEnOFF/oAVt50U1FtgBtfzEQNwHm2GE+gQYTFxqeh5 5M9ZBTYz+dPsCf0q6spsU4HviKsbI8IsmV6HUe7mxIvztHvI6380Z51GcTFhPvGHAHyt IOt4LgYaD1yDxSp+1vtc05+cciME/5nObQyay0RVlfujeVO/7yjdTsn8ymN2v5dO97K/ iL2A== X-Gm-Message-State: ACrzQf2FOMzUFY6dcPYVVaY5zye8SLXYPM9V+sXdYFLHkqZGEkapumCx cO07tUWXBkgp3zVNUuqLx9rrVEbFF5sxl8Ccyr2UywUjnz0= X-Google-Smtp-Source: AMsMyM41uMS+FD68qwwLGl6hu1woCcqeAkNYbFfgNJDStLVFMhhoEWpyt4lOTwxWjgV6yV9zRUQIDMYIkJo5Non03IE= X-Received: by 2002:a17:90a:bb94:b0:209:618f:46ac with SMTP id v20-20020a17090abb9400b00209618f46acmr2527786pjr.240.1664932624459; Tue, 04 Oct 2022 18:17:04 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202210041153.294Br4Si011556@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Tue, 4 Oct 2022 21:16:54 -0400 Message-ID: Subject: Re: git: d97ecf714e79 - main - time(3): Increase precision of time conversion functions by using gcd. To: Hans Petter Selasky Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MhxW60ZFnz3YgK X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, 4 Oct 2022 at 15:53, Hans Petter Selasky wrote: > > On 10/4/22 18:41, John Baldwin wrote: > > > > For future reference: Phab only auto-closes a review if the Differential > > Revision > > tag is the last tag in the commit log. This is why it is listed last in > > the > > commit log template. > > > > I'm a little confused. My phab review did auto close?? Yeah, I think it's actually that "Differential Revision" has to be in the last paragraph (i.e., no blank lines following it). Perhaps this changed with some Phabricator update, as I believe it had to be the last line at one point. Either way by convention it should be the last line.