From owner-freebsd-arch@FreeBSD.ORG Mon Jun 13 20:11:18 2005 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D5BC16A41C for ; Mon, 13 Jun 2005 20:11:18 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from pasmtp.tele.dk (pasmtp.tele.dk [193.162.159.95]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38D2D43D4C for ; Mon, 13 Jun 2005 20:11:18 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (0x535c0e2a.sgnxx1.adsl-dhcp.tele.dk [83.92.14.42]) by pasmtp.tele.dk (Postfix) with ESMTP id A93D21EC32B for ; Mon, 13 Jun 2005 22:11:12 +0200 (CEST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.4/8.13.3) with ESMTP id j5DKB3Sk014712; Mon, 13 Jun 2005 22:11:03 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Antoine Brodin From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 13 Jun 2005 22:07:57 +0200." <20050613220757.1063996b.antoine.brodin@laposte.net> Date: Mon, 13 Jun 2005 22:11:03 +0200 Message-ID: <14711.1118693463@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: arch@freebsd.org Subject: Re: simplify disksort, please review. X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2005 20:11:18 -0000 In message <20050613220757.1063996b.antoine.brodin@laposte.net>, Antoine Brodin writes: >bioq_insert_head and bioq_insert_tail should perhaps be modified when >they're called from outside of subr_disk.c too, to insert just before >insert_point and replace it in the head case... but this probably >affects sorting of later bios... I think that would be a pointless complication of the code... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.