From owner-svn-src-head@FreeBSD.ORG Thu Mar 31 19:34:38 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02BA11065670; Thu, 31 Mar 2011 19:34:38 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id AD2B18FC18; Thu, 31 Mar 2011 19:34:37 +0000 (UTC) Received: from [10.30.101.54] ([209.117.142.2]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p2VJTHQp010763 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Thu, 31 Mar 2011 13:29:19 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <201103310740.20265.jhb@freebsd.org> Date: Thu, 31 Mar 2011 13:29:11 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <73CB36BD-1C9E-4992-A3C7-B540ABB7F11E@bsdimp.com> References: <201103310807.p2V87DHV096049@svn.freebsd.org> <201103310740.20265.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1082) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Thu, 31 Mar 2011 13:29:19 -0600 (MDT) Cc: svn-src-head@FreeBSD.org, Adrian Chadd , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r220185 - in head/sys: amd64/conf arm/conf conf dev/ath i386/conf mips/conf modules modules/ath modules/ath_ahb modules/ath_pci pc98/conf sparc64/conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2011 19:34:38 -0000 On Mar 31, 2011, at 5:40 AM, John Baldwin wrote: > On Thursday, March 31, 2011 4:07:13 am Adrian Chadd wrote: >> Author: adrian >> Date: Thu Mar 31 08:07:13 2011 >> New Revision: 220185 >> URL: http://svn.freebsd.org/changeset/base/220185 >>=20 >> Log: >> Break out the ath PCI logic into a separate device/module. >>=20 >> Introduce the AHB glue for Atheros embedded systems. Right now it's >> hard-coded for the AR9130 chip whose support isn't yet in this HAL; >> it'll be added in a subsequent commit. >>=20 >> Kernel configuration files now need both 'ath' and 'ath_pci' = devices; both >> modules need to be loaded for the ath device to work. >=20 > Err, there's no need to break the kernel config. Just have the kernel = DTRT if=20 > both ath and pci are enabled using something like: >=20 > sys/dev/ath/if_ath_pci.c ath pci >=20 > in sys/conf/files. >=20 > You can still have an if_ath_pci.ko module with this arrangement. = This is=20 > what almost all other drivers due that have multiple bus backends. Well, most drivers with multiple back ends compile all the relevant ones = for the platform in. There's very few that call out individual ones = (ata and its kin being the big exception). Personally, I'd not bother having a if_ath_pci.ko, and instead bundle it = in with if_ath.ko and omitting if_ath_ahb.c from the x86 builds, but I = understand why this might be important in the embedded builds. Warner=