From owner-svn-ports-head@freebsd.org Mon Dec 25 19:51:55 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F3CFEA2E72; Mon, 25 Dec 2017 19:51:55 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay106.isp.belgacom.be (mailrelay106.isp.belgacom.be [195.238.20.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign Organization Validation CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2FAC070A92; Mon, 25 Dec 2017 19:51:53 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes IronPort-PHdr: =?us-ascii?q?9a23=3ABKKUHxZWgNG/HvODJvUh153/LSx+4OfEezUN459i?= =?us-ascii?q?sYplN5qZpsyybR7h7PlgxGXEQZ/co6odzbaO6ua4ASQp2tWoiDg6aptCVhsI24?= =?us-ascii?q?09vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFRrhKAF7?= =?us-ascii?q?Ovr6GpLIj8Swyuu+54Dfbx9HiTahfL9+Ngm6oRnMvcQKnIVuLbo8xAHUqXVSYe?= =?us-ascii?q?RWwm1oJVOXnxni48q74YBu/SdNtf8/7sBMSar1cbg2QrxeFzQmLns65Nb3uhnZ?= =?us-ascii?q?TAuA/WUTX2MLmRdVGQfF7RX6XpDssivms+d2xSeXMdHqQb0yRD+v9LlgRgP2hy?= =?us-ascii?q?gbNj456GDXhdJ2jKJHuxKquhhzz5fJbI2JKPZye6XQds4YS2VcRMZcTyJPDIOi?= =?us-ascii?q?YYUSDOQOP+hYoIbhqFUBtha+GQuhCP/zxjNUmnP6w6s32PkhHwHc2wwgGsoDvm?= =?us-ascii?q?rVrNX3MKcZTP64zK7PzTXYcfxW3C3y6I7Tchs8pvyMQbNwccjVyUQ0Fw3FlEuf?= =?us-ascii?q?ppL4Mj2I2OoBqW+b7/BvVe+2jWMstg9/oj+qxsg2i4nJgJoYyl7e9Spn3ok6Ps?= =?us-ascii?q?a4R1Nhbd6jCptQuDmWNop3Qsw5WW1npTg1x7sbspC4ZCgH0JcqywPFZ/CZfIWE?= =?us-ascii?q?/gjvWemTLDtimn5pZKyzihCv+ka60OL8TNO70FNSoypAldnDq24C2gTI6siCVv?= =?us-ascii?q?t95kCh2SuT1wzL6uFLP0Q0la3DJp4i2LEwkpsTsUHdES/sn0X6lrOWdkQm+uis?= =?us-ascii?q?8ejofrLmppiHN4BqjwHxKKIumtelDeQ/KAgOUHCX+eW61LL94U30WLZHguAsnq?= =?us-ascii?q?XHv53WOd4Xq6G7DgNPzIov9wizAy+j0NsCnHkHKFxFeAiAj4jsI1zOPPH4DfW7?= =?us-ascii?q?g1m3njdr3e7JMaP6DZXWM3fPirDhfaxy60JE0go80chf545ICrEGOP/8QFL+u8?= =?us-ascii?q?bdDh43KAG0zfznB8tj2YwFQmKAH7WVMKTIsV+H/ugvOfWDZJcJuDbhLPgo/+Xu?= =?us-ascii?q?jWE/mVMEZamp2oEXaGyjHvh/I0WWf2DjjcoaHGcEpAoxUvLlh0aZUTFOfXqyWL?= =?us-ascii?q?g85j4jAoK8EYjDXpytgKCG3CqjBZ1WeGZGBkmUEXfvbYWER+wMZDuILc9lljwJ?= =?us-ascii?q?TrahS5U/2h6wrwD60KdoIvDT+i0CupLpzMJ16PHLlREu6Tx0CNyQ03mKT2Fugm?= =?us-ascii?q?MIXCY607x4oUx4z1eD0LR4g+BGGtxJ/PNESQk6NYTCwONkEN/yQR/Ocs2OSFa8?= =?us-ascii?q?TdWsGSsxQc4pw98Sf0Z9HM2vjxDe3yqwAr8YjLKLBIYq/a3CxHfxPNtyx2zB1K?= =?us-ascii?q?k7gFl1CvdIYFy7nK83yQnYG4nTlFuYnKbiIbUBxi/l2n2OwEC1kAdfSgEmFe3M?= =?us-ascii?q?UXkaeWP4t9n0zHjuCbi0BucJKAxEnPKDKK8CQdrullhDTfH4cIDCYmC1s0mqCB?= =?us-ascii?q?ui/Z/Ka5DlLTZOlB7BAVQJxlhAtU2NMhIzU2L4+zrT?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2A9BgCcVUFa/8ov8FFdGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYM+RhAQdBQTjx6Nfx0BAYIAMwGHKZFhLYUYAoRRQxUBAQEBAQE?= =?us-ascii?q?BAQEBaiiCOCQBgkYBAQEBAgE6HCMFCwsUBAklDyoeBgESiiYMDKVDEYNNikwBA?= =?us-ascii?q?QEBAQEBAQIBAQEBAQEBASCEDIFog2mDLoMkDIFuhXwFo0yIA40lgQCCCZEBjDl?= =?us-ascii?q?rixs1I4FPTDAIgmYJhE9AN4sBAQEB?= X-IPAS-Result: =?us-ascii?q?A2A9BgCcVUFa/8ov8FFdGQEBAQEBAQEBAQEBAQcBAQEBAYM?= =?us-ascii?q?+RhAQdBQTjx6Nfx0BAYIAMwGHKZFhLYUYAoRRQxUBAQEBAQEBAQEBaiiCOCQBg?= =?us-ascii?q?kYBAQEBAgE6HCMFCwsUBAklDyoeBgESiiYMDKVDEYNNikwBAQEBAQEBAQIBAQE?= =?us-ascii?q?BAQEBASCEDIFog2mDLoMkDIFuhXwFo0yIA40lgQCCCZEBjDlrixs1I4FPTDAIg?= =?us-ascii?q?mYJhE9AN4sBAQEB?= Received: from 202.47-240-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.240.47.202]) by relay.skynet.be with ESMTP; 25 Dec 2017 20:50:39 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id vBPJocBh047003; Mon, 25 Dec 2017 20:50:39 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Mon, 25 Dec 2017 20:50:38 +0100 From: Tijl Coosemans To: Yuri Victorovich , adamw@FreeBSD.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457249 - in head/math: . SCIP Message-ID: <20171225205038.29a0c816@kalimero.tijl.coosemans.org> In-Reply-To: <201712251903.vBPJ3UpP037293@repo.freebsd.org> References: <201712251903.vBPJ3UpP037293@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Dec 2017 19:51:55 -0000 On Mon, 25 Dec 2017 19:03:30 +0000 (UTC) Yuri Victorovich wrote: > Author: yuri > Date: Mon Dec 25 19:03:30 2017 > New Revision: 457249 > URL: https://svnweb.freebsd.org/changeset/ports/457249 > > Log: > New port: math/SCIP: Solver for mixed integer, mixed integer nonlinear programming > > Submitted by: myself > Approved by: adamw (mentor) > Differential Revision: https://reviews.freebsd.org/D13614 > > Added: > head/math/SCIP/ > head/math/SCIP/Makefile (contents, props changed) > head/math/SCIP/distinfo (contents, props changed) > head/math/SCIP/pkg-descr (contents, props changed) > head/math/SCIP/pkg-plist (contents, props changed) > Modified: > head/math/Makefile > > Modified: head/math/Makefile > ============================================================================== > --- head/math/Makefile Mon Dec 25 19:01:08 2017 (r457248) > +++ head/math/Makefile Mon Dec 25 19:03:30 2017 (r457249) > @@ -91,6 +91,7 @@ > SUBDIR += R-cran-units > SUBDIR += R-cran-xts > SUBDIR += R-cran-zoo > + SUBDIR += SCIP > SUBDIR += SoPlex > SUBDIR += aamath > SUBDIR += abacus > > Added: head/math/SCIP/Makefile > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/math/SCIP/Makefile Mon Dec 25 19:03:30 2017 (r457249) > @@ -0,0 +1,27 @@ > +# Created by: Yuri Victorovich > +# $FreeBSD$ > + > +PORTNAME= SCIP > +DISTVERSION= 5.0.0 > +CATEGORIES= math science > +MASTER_SITES= http://scip.zib.de/download/release/ > +DISTNAME= ${PORTNAME:tl}-${DISTVERSION} Surely, if upstream names their packages using lower case... > Added: head/math/SCIP/pkg-plist > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/math/SCIP/pkg-plist Mon Dec 25 19:03:30 2017 (r457249) > @@ -0,0 +1,436 @@ > +bin/scip ...names their binaries,... > +include/scip/bandit.h > +include/scip/bandit_epsgreedy.h > +include/scip/bandit_exp3.h > +include/scip/bandit_ucb.h ...headers and... > +lib/cmake/scip/scip-config.cmake > +lib/cmake/scip/scip-targets-%%CMAKE_BUILD_TYPE%%.cmake > +lib/cmake/scip/scip-targets.cmake > +lib/libscip.so > +lib/libscip.so.%%SHL2%% > +lib/libscip.so.%%SHL4%% ...libraries all lower case, our port and package should also be lower case. I'm not as extreme as danfe on the use of upper case, but I do think it should be kept to a minimum in the ports tree. And this is not an aesthetic thing. Your adding of upper case everywhere is breaking tradition in the ports tree and causing inconsistency.