From nobody Mon Feb 2 22:45:44 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f4hXs58Rqz6QfN1 for ; Mon, 02 Feb 2026 22:45:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f4hXs2zrSz4M0X for ; Mon, 02 Feb 2026 22:45:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770072349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mlhOEy0mFfjWwbYFvQR4KMeoJFaT+Q5B/3PUzg7saRQ=; b=WssCiiMzhZhMObkDt3D451PnsGfHvpQZjVvhc8SwdFNe5Tvvex72sDCGcGYLDi0EhHklnf u0ImZdLMzRa9BSdJf4eoYtRRGz5sGBF3JZjQonLMusVbEOULCqsDdhoz/0GirXnKOwbYSo NdhmiWUQBFmRU+xML0FiFN1xgqa5aKTDYBJyPUJmDN2pmQ6uqsJlU19DLssgo17bKd2AM8 d6w2UmmRhvUZW6aFbsLx93O7ScYjUAra+oem+8Mnpaet0JxaFd9nm3tJFJeKQFHfFATQab voXXkWjBGdX9T0npoJOMb49NxXyqO6Z8bNSxMMW8f63Cbbm6ukm8me72gNqNbQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770072349; a=rsa-sha256; cv=none; b=i0VriboosdXS3rIfG6tuJgo4GUKOAK94SP+ELygK2lgBYORsWcB0Mkaj3KP2HjeR9i18Vx iG65yXEuoyPPscZA1UZ4a/h76rFUNJu6uoq7di4V43CKylfZs5dd3lrsqRuIep9cM8xtYv G9WriH2abvCbruUv0aTDw1OOLFcM9irIRDDFX2EzhEPt9PcFn5VUz14ZrKA9YgDJ6qNNjO t0bnagYzUOHkdjLL5Z1djcNCn1oPVAyQRV0zgpIxL0nJtx4STVtZaENIja1Myo1eUjpxBe LAas68nkCg3V+B3tRQecS955Ic1s9IAa5ndHiYzgOoR0mlg0cT7A2m7LyxLfwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770072349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mlhOEy0mFfjWwbYFvQR4KMeoJFaT+Q5B/3PUzg7saRQ=; b=QcfKAM71BXNO/7i4S+Vht9p+BoJkMU7BuqTl2NrC5/1SMc9GLhkB/Y+5rphN9MD8K+e3yY 6PvP+r+5WGahhF4yvBQSSGvGEqp4W7ObT1Z+h8hdEuB0+d2l0nNF6w6B2vV4lNhyUsEn3s nyjfdoJPgmSNAI6jQ2+4oWRDNT9bGAGkDOPKuoNPsvnjS+nToWwCQ1PED6I5cBepwoRanw TkuXkLISV31uyuwiXqfcn9ZkZlhitCFO/tjpgCnNbluOeF5SpKavd/gfL16qz5w/212U2b /lfAt8Rxn1PfV/L/tIek+9gRwBnl2M5Y6zgWHBOK+qx+4ePIezZ2oIbUTQo5yw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f4hXs2ZtVzmZq for ; Mon, 02 Feb 2026 22:45:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 180b2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Feb 2026 22:45:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: John Baldwin From: Enji Cooper Subject: git: a2a9a77ce005 - stable/15 - heimdal: Pass the correct pointer to realloc when growing a string buffer List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a2a9a77ce005ac3a07b68d98f6451fa90b9827d6 Auto-Submitted: auto-generated Date: Mon, 02 Feb 2026 22:45:44 +0000 Message-Id: <69812918.180b2.1c755da5@gitrepo.freebsd.org> The branch stable/15 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=a2a9a77ce005ac3a07b68d98f6451fa90b9827d6 commit a2a9a77ce005ac3a07b68d98f6451fa90b9827d6 Author: John Baldwin AuthorDate: 2026-02-02 17:18:11 +0000 Commit: Enji Cooper CommitDate: 2026-02-02 22:45:33 +0000 heimdal: Pass the correct pointer to realloc when growing a string buffer The realloc in my_fgetln was trying to grow the pointer to the string buffer, not the string buffer itself. In function 'my_fgetln', inlined from 'mit_prop_dump' at crypto/heimdal/kdc/mit_dump.c:156:19: crypto/heimdal/kdc/mit_dump.c:119:13: error: 'realloc' called on unallocated object 'line' [-Werror=free-nonheap-object] 119 | n = realloc(buf, *sz + (*sz >> 1)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ crypto/heimdal/kdc/mit_dump.c: In function 'mit_prop_dump': crypto/heimdal/kdc/mit_dump.c:139:11: note: declared here 139 | char *line = NULL; | ^~~~ Reviewed by: rmacklem, cy Fixes: a93e1b731ae4 ("heimdal-kadmin: Add support for the -f dump option") Differential Revision: https://reviews.freebsd.org/D54933 (cherry picked from commit 03d8ac948b1ad9c419b294c3129b7da58d818363) --- crypto/heimdal/kdc/mit_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/kdc/mit_dump.c b/crypto/heimdal/kdc/mit_dump.c index 4397d1ad897d..d790b145af11 100644 --- a/crypto/heimdal/kdc/mit_dump.c +++ b/crypto/heimdal/kdc/mit_dump.c @@ -116,7 +116,7 @@ my_fgetln(FILE *f, char **buf, size_t *sz, size_t *len) return 0; } *len += strlen(&(*buf)[*len]); /* *len should be == *sz */ - n = realloc(buf, *sz + (*sz >> 1)); + n = realloc(*buf, *sz + (*sz >> 1)); if (!n) { free(*buf); *buf = NULL;