From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Feb 25 04:06:13 2007 Return-Path: X-Original-To: freebsd-ports-bugs@freebsd.org Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8B6AE16A400 for ; Sun, 25 Feb 2007 04:06:13 +0000 (UTC) (envelope-from sbenabas@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.freebsd.org (Postfix) with ESMTP id 234FB13C481 for ; Sun, 25 Feb 2007 04:06:12 +0000 (UTC) (envelope-from sbenabas@gmail.com) Received: by nf-out-0910.google.com with SMTP id k27so1109483nfc for ; Sat, 24 Feb 2007 20:06:12 -0800 (PST) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; b=FwhE02dI3OW3lCXf9iuPdhzi04DmymRRU4XuT82HJh1Vp+wKUfMe8ysPqA2twPG8yBWKMqM16UTaYPxFhivKUhCqRYhnPQ1WkQ2pnrlQGCX3mRUPQHjpTyAv93IchezHLSeuOF6Znh/nTsBC2poXPx2PV8t5mDsahiWz0KC/k10= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type; b=jInNX54ms+274b+A6toLe/O7c8ky0Vcjsv3VUXU3dfLkWH36INy8uA2LyemtXjZxWwL39XZczVfCXQ+TzFqTTThqP5Ik6adGSO0hXZ75BZdgZWGm1CpI6QG5gyi/MIG0amDry7hgv5Evnz0kw4bA4fFqMf1OSiHSABkKhMk9uHk= Received: by 10.78.83.15 with SMTP id g15mr322628hub.1172374807230; Sat, 24 Feb 2007 19:40:07 -0800 (PST) Received: by 10.78.158.7 with HTTP; Sat, 24 Feb 2007 19:40:07 -0800 (PST) Message-ID: <32d8477c0702241940y7d5b57dfycd3b8773cafac0ae@mail.gmail.com> Date: Sat, 24 Feb 2007 22:40:07 -0500 From: "Siavosh Benabbas" To: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_30303_31460567.1172374807205" Subject: ffmpeg-devel port's Makefile can corrupt makefile's (ports/104427) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Feb 2007 04:06:13 -0000 ------=_Part_30303_31460567.1172374807205 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello All, I filed this http://www.freebsd.org/cgi/query-pr.cgi?pr=104427 PR some time ago but it was never fixed/closed. I don't know if this is the right list but I will post it anyway. Sorry for cross posting. Basically the ffmpeg-devel port's Makefile has a ${REINPLACE_CMD} line ${REINPLACE_CMD} -E \ -e 's@^(CFLAGS.+)$$@\1 ${FFMPEG_CFLAGS}@' \ -e 's@^(FFLIBS|LDFLAGS)(.+)$$@\1\2 ${FFMPEG_LDFLAGS}@' This would corrupt the Makefile if a CFLAGS assignment is split over multiple lines using \ at the end of the lines. These long assignments are present in new ffmpeg sources (the current ffmpeg-devel port is very outdated). I have also posted a patch which brings all such lines to the sed pattern space and fixes the problem, it is attached. Please CC me as I am not on the list. Thanks, Siavosh Benabbas ------=_Part_30303_31460567.1172374807205 Content-Type: text/x-patch; name=patch-1.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_eybph81u Content-Disposition: attachment; filename="patch-1.diff" LS0tIE1ha2VmaWxlLm9yaWcJU2F0IE9jdCAxNCAxNTozODozOSAyMDA2CisrKyBNYWtlZmlsZQlT YXQgT2N0IDE0IDIyOjQ2OjA1IDIwMDYKQEAgLTQ3NCw2ICs0NzQsOCBAQAogCUAke0ZJTkR9ICR7 V1JLRElSfSAtdHlwZSBmIC1uYW1lICJNYWtlZmlsZSIgLXByaW50MCB8IFwKIAkJJHtYQVJHU30g LTAgLW4gNSAteCBcCiAJCQkke1JFSU5QTEFDRV9DTUR9IC1FIFwKKwkJCS1lICc6YWdhaW4nIC1l ICcvLipcXCQkL04nIC1lICdzLyguKilcXCQkL1wxXFwvZycgXAorCQkJLWUgJ3QgYWdhaW4nIFwK IAkJCS1lICdzQF4oQ0ZMQUdTLispJCRAXDEgJHtGRk1QRUdfQ0ZMQUdTfUAnIFwKIAkJCS1lICdz QF4oRkZMSUJTfExERkxBR1MpKC4rKSQkQFwxXDIgJHtGRk1QRUdfTERGTEFHU31AJwogIyBmaXgg eDI2NCBtYXRoLCB1c2UgY29ycmVjdCBsb2cgYmFzZSAyIGZyb20gbWF0aCgzKQoK ------=_Part_30303_31460567.1172374807205--