From owner-cvs-all@FreeBSD.ORG Mon Sep 18 19:27:05 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B91CE16A4D4; Mon, 18 Sep 2006 19:27:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDF4643D99; Mon, 18 Sep 2006 19:25:06 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k8IJOpPS077960; Mon, 18 Sep 2006 15:24:53 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andre Oppermann Date: Mon, 18 Sep 2006 13:54:18 -0400 User-Agent: KMail/1.9.1 References: <200609171333.k8HDXUht029746@repoman.freebsd.org> In-Reply-To: <200609171333.k8HDXUht029746@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609181354.19593.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 18 Sep 2006 15:24:53 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1892/Mon Sep 18 07:53:36 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/bge if_bge.c src/sys/dev/em if_em.c src/sys/dev/ixgb if_ixgb.c src/sys/dev/nfe if_nfe.c src/sys/dev/nge if_nge.c src/sys/dev/re if_re.c src/sys/dev/stge if_stge.c src/sys/dev/ti if_ti.c src/sys/dev/txp ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2006 19:27:05 -0000 On Sunday 17 September 2006 09:33, Andre Oppermann wrote: > andre 2006-09-17 13:33:30 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bce if_bce.c > sys/dev/bge if_bge.c > sys/dev/em if_em.c > sys/dev/ixgb if_ixgb.c > sys/dev/nfe if_nfe.c > sys/dev/nge if_nge.c > sys/dev/re if_re.c > sys/dev/stge if_stge.c > sys/dev/ti if_ti.c > sys/dev/txp if_txp.c > sys/dev/vge if_vge.c > sys/net if_vlan.c if_vlan_var.h > sys/net80211 ieee80211_input.c ieee80211_output.c > sys/netgraph ng_vlan.c > sys/sys mbuf.h > Log: > Move ethernet VLAN tags from mtags to its own mbuf packet header field > m_pkthdr.ether_vlan. The presence of the M_VLANTAG flag on the mbuf > signifies the presence and validity of its content. Did you ever get a chance to benchmark this? I know in principle it should be faster, but as I had mentioned to you earlier, sometimes things that seem like they should be faster end up being slower, so it's generally helpful to verify one's assumptions with actual benchmarks or testing, etc. Also, it would have been helpful to have Robert's review on this as he has been talking about moving the vlan stuff into the ether input/output routines for quite a while now. -- John Baldwin