From owner-dev-commits-src-all@freebsd.org Tue Jan 5 23:11:07 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 69F034D444B; Tue, 5 Jan 2021 23:11:07 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D9Ssk3Yytz3pnW; Tue, 5 Jan 2021 23:11:06 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id C366E3C0199; Tue, 5 Jan 2021 23:11:00 +0000 (UTC) Date: Tue, 5 Jan 2021 23:11:00 +0000 From: Brooks Davis To: Alan Somers Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 022ca2fc7fe0 - main - Add aio_writev and aio_readv Message-ID: <20210105231100.GD94898@spindle.one-eyed-alien.net> References: <202101030259.1032x5hV006606@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XWOWbaMNXpFDWE00" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 4D9Ssk3Yytz3pnW X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-3.90 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[brooks]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[199.48.129.229:from]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[199.48.129.229:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 23:11:07 -0000 --XWOWbaMNXpFDWE00 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 02, 2021 at 10:09:04PM -0700, Alan Somers wrote: > On Sat, Jan 2, 2021 at 9:39 PM Jessica Clarke wrote: >=20 > > On 3 Jan 2021, at 02:59, Alan Somers wrote: > > > diff --git a/sys/kern/syscalls.master b/sys/kern/syscalls.master > > > index b7ea5e939635..aaa0a1277461 100644 > > > --- a/sys/kern/syscalls.master > > > +++ b/sys/kern/syscalls.master > > > @@ -1477,7 +1477,17 @@ > > > _In_opt_ struct sigevent *sig > > > ); > > > } > > > -258-271 AUE_NULL UNIMPL nosys > > > +258 AUE_AIO_WRITEV STD { > > > + int aio_writev( > > > + _Inout_ struct aiocb *aiocbp > > > + ); > > > + } > > > +259 AUE_AIO_READV STD { > > > + int aio_readv( > > > + _Inout_ struct aiocb *aiocbp > > > + ); > > > + } > > > +260-271 AUE_NULL UNIMPL nosys > > > 272 AUE_O_GETDENTS COMPAT11 { > > > int getdents( > > > int fd, > > > > Should these not be added to the end? > > > > Jess > > >=20 > Should they be? I'm not aware of any requirement to add new syscalls to > the end. I put them here so they would be next to the other AIO syscalls. Yes. I'm sorry I missed this in the review. It's vastly easier to audit these files and address conflicts if they are append-only. We're also using these syscall numbers internally specifically to avoid conflicts with new syscalls. Please move them to the end. I do see that we only provide extremely outdated advice in the comments of syscalls.master. I'll take a look at improving this and the wiki page. Thanks, Brooks --XWOWbaMNXpFDWE00 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJf9PIEAAoJEKzQXbSebgfA/eUH/2Bi73K4kSotDeSO7wbxxeIp glg+uiB2fXFeSUH1IGwT6wcR1NgDSgaIOMw9N85e6zpoCVyaU+wwJD/I8i/sSWlS 9ZLhawDObcDR1CpDcoD+8AJ70wnbFQZx90RUXvbDxiUThHm2XoUiJPoRGx3LRFhd LiEWsWqGgcMPSsqB4tMBtgK3p2E/6SKXjkt+bppHraTp3Z8Bo88+lhdjEzYhB2AT FzgkC1RZQt+6MjwZmYUmMW1B7rLU2Za6nO0x2wWHhgfkqJI31cvNG+knAL76fA0j 3vFwxfU1+K4VFD58CmQhYZOnTPbrz756ivnzZF+u5IkhKl/Z7W3smozjE1aoQ/c= =Xoi+ -----END PGP SIGNATURE----- --XWOWbaMNXpFDWE00--