From owner-cvs-src Tue Feb 25 20:53:13 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7D3437B405; Tue, 25 Feb 2003 20:53:10 -0800 (PST) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0DE143FA3; Tue, 25 Feb 2003 20:53:09 -0800 (PST) (envelope-from scott_long@btc.adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h1Q4qOF07362; Tue, 25 Feb 2003 20:52:24 -0800 Received: from btc.btc.adaptec.com (btc.btc.adaptec.com [10.100.0.52]) by redfish.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id UAA22960; Tue, 25 Feb 2003 20:52:57 -0800 (PST) Received: from btc.adaptec.com (hollin [10.100.253.56]) by btc.btc.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id VAA10697; Tue, 25 Feb 2003 21:52:52 -0700 (MST) Message-ID: <3E5C4821.9070501@btc.adaptec.com> Date: Tue, 25 Feb 2003 21:52:49 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.2.1) Gecko/20030206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Daniel O'Connor" Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/aac aac.c aac_cam.c aac_disk.c aacvar.h References: <200302260446.h1Q4kLO6042833@repoman.freebsd.org> <1046234946.45422.98.camel@chowder.gsoft.com.au> In-Reply-To: <1046234946.45422.98.camel@chowder.gsoft.com.au> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Daniel O'Connor wrote: > On Wed, 2003-02-26 at 15:16, Scott Long wrote: > >> - the mutex aac_io_lock protects the main codepaths which handle queues and >> hardware registers. Only one acquire/release is done in the top-half and >> the taskqueue. This mutex also applies to the userland command path and >> CAM data path. >> - Move the taskqueue to the new Giant-free version. >> - Register the disk device with DISKFLAG_NOGIANT so the top-half processing >> runs without Giant. >> - Move the dynamic command allocator to the worker thread to avoid locking >> issues with bus_dmamem_alloc(). >> >> This gives about 20% improvement in most of my benchmarks. > > > Are the tests on an SMP machine? > Yes. UP probably won't see much of a difference. Scott To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message