From owner-cvs-all@FreeBSD.ORG Wed Oct 6 15:36:16 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E482A16A4CE; Wed, 6 Oct 2004 15:36:16 +0000 (GMT) Received: from portpc-design.spb.ru (ns2.portpc-design.spb.ru [195.161.118.232]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DEB843D4C; Wed, 6 Oct 2004 15:36:16 +0000 (GMT) (envelope-from mcsi@mcsi.pp.ru) Received: from [83.237.13.114] (ppp83-237-13-114.pppoe.mtu-net.ru [83.237.13.114]) (authenticated bits=0) by portpc-design.spb.ru (8.13.1/8.13.1) with ESMTP id i96FaA5c083753; Wed, 6 Oct 2004 19:36:10 +0400 (MSD) (envelope-from mcsi@mcsi.pp.ru) Message-ID: <416410E5.7000405@mcsi.pp.ru> Date: Wed, 06 Oct 2004 19:36:05 +0400 From: Maxim Maximov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: ru, en-us, en MIME-Version: 1.0 To: Mike Makonnen References: <200410061420.i96EKwvd040396@repoman.freebsd.org> In-Reply-To: <200410061420.i96EKwvd040396@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.64 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on portpc-design.spb.ru cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libthr/threadthr_exit.csrc/sys/compat/freebsd32 syscalls.master src/sys/kern kern_thr.c src/sys/sys thr.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2004 15:36:17 -0000 Mike Makonnen wrote: > mtm 2004-10-06 14:20:58 UTC > > FreeBSD src repository > > Modified files: > lib/libthr/thread thr_exit.c > sys/compat/freebsd32 syscalls.master > sys/kern kern_thr.c > sys/sys thr.h > Log: > Close a race between a thread exiting and the freeing of it's stack. > After some discussion the best option seems to be to signal the thread's > death from within the kernel. This requires that thr_exit() take an > argument. > > Discussed with: davidxu, deischen, marcel > MFC after: 3 days Just cvsupped source fails to build: cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror /usr/src/sys/kern/kern_thr.c /usr/src/sys/kern/kern_thr.c: In function `thr_exit': /usr/src/sys/kern/kern_thr.c:196: error: structure has no member named `state' /usr/src/sys/kern/kern_thr.c:197: error: structure has no member named `state' *** Error code 1 Stop in /usr/obj/usr/src/sys/ULTRA. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Exit 1 -- Maxim Maximov