From owner-freebsd-hackers@freebsd.org  Mon Jan  8 16:18:03 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCE8CE75447
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Mon,  8 Jan 2018 16:18:03 +0000 (UTC)
 (envelope-from eugen@grosbein.net)
Received: from hz.grosbein.net (hz.grosbein.net [78.47.246.247])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D34383001;
 Mon,  8 Jan 2018 16:18:02 +0000 (UTC)
 (envelope-from eugen@grosbein.net)
Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be
 forged))
 by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id w08GHsAq070167
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 8 Jan 2018 17:17:55 +0100 (CET)
 (envelope-from eugen@grosbein.net)
X-Envelope-From: eugen@grosbein.net
X-Envelope-To: eric@vangyzen.net
Received: from [10.58.0.4] ([10.58.0.4])
 by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id w08GHo5Y041119
 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
 Mon, 8 Jan 2018 23:17:50 +0700 (+07)
 (envelope-from eugen@grosbein.net)
Subject: Re: Is it considered to be ok to not check the return code of
 close(2) in base?
To: Eric van Gyzen <eric@vangyzen.net>, Brooks Davis <brooks@freebsd.org>,
 Alan Somers <asomers@freebsd.org>
References: <24acbd94-c52f-e71a-8a96-d608a10963c6@rawbw.com>
 <1514572041.12000.7.camel@freebsd.org>
 <CAOtMX2jSonHQ9xzVD3Q9XS2twBm_CT3Tquwn+f6zmc7aV0QerQ@mail.gmail.com>
 <20180105221330.GD95035@spindle.one-eyed-alien.net>
 <5A4FF989.1040709@grosbein.net>
 <7b977409-96ee-5acb-60d0-3b0e124495f0@vangyzen.net>
 <5A5002D9.9080205@grosbein.net>
 <d75e9334-4da1-125c-73a5-1115003d12b5@vangyzen.net>
Cc: Yuri <yuri@rawbw.com>, Ian Lepore <ian@freebsd.org>,
 Freebsd hackers list <freebsd-hackers@freebsd.org>
From: Eugene Grosbein <eugen@grosbein.net>
Message-ID: <5A5399AA.9020309@grosbein.net>
Date: Mon, 8 Jan 2018 23:17:46 +0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <d75e9334-4da1-125c-73a5-1115003d12b5@vangyzen.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=2.2 required=5.0 tests=BAYES_00, LOCAL_FROM, RDNS_NONE
 autolearn=no autolearn_force=no version=3.4.1
X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1%
 *      [score: 0.0000]
 *  1.9 RDNS_NONE Delivered to internal network by a host with no rDNS
 *  2.6 LOCAL_FROM From my domains
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jan 2018 16:18:04 -0000

08.01.2018 23:13, Eric van Gyzen wrote:

> Right, which is the reason such bugs are hard to diagnose.  Optionally
> killing the process on close->EBADF would help find buggy code when
> another thread did NOT re-open the file descriptor between the two close
> calls.

Wouldn't "close(f); assert(errno != EBADF);" be better?