From owner-dev-commits-src-all@freebsd.org Wed Dec 30 03:23:04 2020 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2957F4D3BB6; Wed, 30 Dec 2020 03:23:04 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D5Gnh0Qrgz4XBQ; Wed, 30 Dec 2020 03:23:04 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id F01B52FAF1; Wed, 30 Dec 2020 03:23:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f170.google.com with SMTP id z9so10274308qtn.4; Tue, 29 Dec 2020 19:23:03 -0800 (PST) X-Gm-Message-State: AOAM532qNSwV8IrqE6MY8Mk5B7prVN1hHGP2rCwVPTvHpOGicKlYd8vH WBli5MdnnNadeazunasvAhpN7WFX6cUiRBAYX10= X-Google-Smtp-Source: ABdhPJx0P4gE0v4YVSpg9LzEbRgV1LgQ5O0ZGnW8k5hS4OiogNz0UDz9wvirFNVBrYbETm3bITdfvitgmuhkX2ff3/Q= X-Received: by 2002:ac8:729a:: with SMTP id v26mr50929603qto.53.1609298583516; Tue, 29 Dec 2020 19:23:03 -0800 (PST) MIME-Version: 1.0 References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> <3b4bc9dc-e868-4171-829e-682d8aab7369@www.fastmail.com> In-Reply-To: <3b4bc9dc-e868-4171-829e-682d8aab7369@www.fastmail.com> From: Kyle Evans Date: Tue, 29 Dec 2020 21:22:52 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 To: Brandon Bergren Cc: Ryan Libby , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for all branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2020 03:23:04 -0000 On Tue, Dec 29, 2020 at 9:18 PM Brandon Bergren wrote: > > On Tue, Dec 29, 2020, at 7:21 PM, Kyle Evans wrote: > > > > That is an incredibly good question. The latest build for powerpc > > shows that it did in-fact descend into and build libexec/tftpd/tests > > The tests need to get *built* since they're part of the sets, even if they aren't currently *run* nightly on the CI. > Ryan already pointed out the flaw in my logic (they didn't actually get built, I should have checked libexec/tftpd/tests/Makefile), but the fact that they're not run wasn't significant to this discussion -- the problem observed would have been at compile-time due to an unknown standard or because we weren't specifying the appropriate standard (pre-merge).