From owner-svn-src-all@freebsd.org Wed Nov 4 12:10:06 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4A3E045B47B; Wed, 4 Nov 2020 12:10:06 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CR57d6yrvz4fW0; Wed, 4 Nov 2020 12:10:05 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id B9E631B82B; Wed, 4 Nov 2020 12:10:05 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 7F832500C0; Wed, 4 Nov 2020 13:10:03 +0100 (CET) From: "Kristof Provost" To: "Gordon Bergling" Cc: "Mateusz Piotrowski" <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367321 - head/sys/amd64/linux Date: Wed, 04 Nov 2020 13:09:59 +0100 X-Mailer: MailMate (1.13.2r5673) Message-ID: In-Reply-To: <20201104104515.GA83813@lion.0xfce3.net> References: <202011041038.0A4AcPNn082013@repo.freebsd.org> <20201104104515.GA83813@lion.0xfce3.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 12:10:06 -0000 On 4 Nov 2020, at 11:45, Gordon Bergling wrote: > Shouldn't such a commit be approved by someone? > The committer=E2=80=99s guide seems clear that doc committers may fix = comments: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/com= mitter.types.html > doc committers may commit documentation changes to src files, such as = > man pages, READMEs, fortune databases, calendar files, and comment = > fixes without approval from a src committer, subject to the normal = > care and tending of commits. Arguably minor spelling fixes are not worth confusing the blame output = for, but this seems well within the established rules. > And why you just abandoned the differential [1]? > Probably because it timed out. The review had been pending since August. Arguably the differential link should have been included as well, but = it=E2=80=99s hardly important in this case. I don=E2=80=99t think we have= explicit = policies about this. We probably should. Best regards, Kristof