From owner-freebsd-ia64 Thu Jan 9 22:15:25 2003 Delivered-To: freebsd-ia64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7148237B401; Thu, 9 Jan 2003 22:15:22 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26AEE43EB2; Thu, 9 Jan 2003 22:15:22 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 068C32A8A0; Thu, 9 Jan 2003 22:15:22 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Marcel Moolenaar Cc: "David O'Brien" , Scott Long , Takahashi Yoshihiro , re-builders@FreeBSD.ORG, bmah@FreeBSD.ORG, re@FreeBSD.ORG Subject: Re: 5.0-RC3 In-Reply-To: <20030110014820.GB17013@athlon.pn.xcllnt.net> Date: Thu, 09 Jan 2003 22:15:22 -0800 From: Peter Wemm Message-Id: <20030110061522.068C32A8A0@canning.wemm.org> Sender: owner-freebsd-ia64@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Marcel Moolenaar wrote: > On Thu, Jan 09, 2003 at 05:36:49PM -0800, David O'Brien wrote: > > On Thu, Jan 09, 2003 at 05:25:49PM -0800, Marcel Moolenaar wrote: > > > Let's start the release and have Takahashi-san apply Soren's > > > patch as an exception. That way it gets some testing and > > > should increase confidence for a post-RC3 merge. > > > > Actually that is the opposite of what should happen -- we need to have > > Soren's MFC exposed as widely as possible if it is to be in 5.0-R. The > > way we can get wide[r] coverage is putting it in RC3. > > I don't know what the change is, but if it has possible impact on > non-pc98, then yes. Well, without it, the ata driver will assume that all plug-n-play hardware (including acpi enumerated devices) are ata devices and will attempt to probe/attach them. It is nasty. ---------------------------- revision 1.3 date: 2003/01/09 14:00:07; author: sos; state: Exp; lines: +4 -0 Dont probe PnP devices. Submitted by: Takahashi Yoshihiro ---------------------------- --- ata-cbus.c 17 Dec 2002 16:26:22 -0000 1.2 +++ ata-cbus.c 9 Jan 2003 14:00:07 -0000 1.3 @@ -60,4 +60,8 @@ int rid; u_long tmp; + + /* dont probe PnP devices */ + if (isa_get_vendorid(dev)) + return (ENXIO); /* allocate the ioport range */ This is a no-brainer and should be MFC'ed. IMHO, dont even wait for sos. Just Do It. We have this code on all the isa drivers that do not have a specific list of PNP id's. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ia64" in the body of the message