From owner-freebsd-java@FreeBSD.ORG Thu May 29 10:53:22 2003 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5561537B405 for ; Thu, 29 May 2003 10:53:22 -0700 (PDT) Received: from mgr5.xmission.com (mgr5.xmission.com [198.60.22.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC38A43FB1 for ; Thu, 29 May 2003 10:53:20 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: from mail by mgr5.xmission.com with spam-scanned (Exim 3.35 #1) id 19LRaa-0008VQ-05 for freebsd-java@freebsd.org; Thu, 29 May 2003 11:53:20 -0600 Received: from [207.135.128.145] (helo=misty.eyesbeyond.com) by mgr5.xmission.com with esmtp (Exim 3.35 #1) id 19LRaW-0008Tw-05; Thu, 29 May 2003 11:53:17 -0600 Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.12.9/8.12.9) with ESMTP id h4THweMP031248; Thu, 29 May 2003 11:58:40 -0600 (MDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.12.9/8.12.9/Submit) id h4THwbi6031247; Thu, 29 May 2003 11:58:37 -0600 (MDT) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Thu, 29 May 2003 11:58:37 -0600 From: Greg Lewis To: Herve Quiroz Message-ID: <20030529175837.GA31122@misty.eyesbeyond.com> References: <20030514.125107.74756915.haro@kgt.co.jp> <20030520181421.GB28600@misty.eyesbeyond.com> <20030523072854.GA61661@misty.eyesbeyond.com> <20030523140852.H81713@puget.esil.univ-mrs.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030523140852.H81713@puget.esil.univ-mrs.fr> User-Agent: Mutt/1.4.1i X-Spam-Status: No, hits=-9.2 required=8.0 tests=BAYES_10,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REFERENCES,REPLY_WITH_QUOTES,USER_AGENT_MUTT,X_AUTH_WARNING version=2.54 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.54 (1.174.2.17-2003-05-11-exp) cc: freebsd-java@freebsd.org Subject: Re: bsd.java.mk 2.0 X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2003 17:53:22 -0000 On Fri, May 23, 2003 at 02:31:29PM +0200, Herve Quiroz wrote: > Hi Greg, > > On Fri, 23 May 2003, Greg Lewis wrote: > > > > > This may need extending to cope with ports that need a JDK at run time > > > > (any examples?). > > > > > > devel/jakarta-ant ? > > > > Good call. How about: > > > > USE_JAVA = [ BUILD-RUN ] > > > > Where BUILD and RUN may take the values jdk or jre. I think this should > > be clear, but the BUILD portion adds a build depends and the RUN portion > > adds a run depends. The most common case will be jdk-jre, meaning the > > port requires the JDK to build but only the jre to run. > > > > This kinda feels a little clunky, so as an alternative maybe: > > > > USE_JAVA = yes > > JAVA_BUILD = jdk > > JAVA_RUN = jre > > > > Comments? > > At first, I would have said I prefer the second. But I don't know really. > Maybe with an example I can figure what you mean exactly. Tell me f I > understand correctly: > > For most of the ports (libs): > USE_JAVA= BUILD=jdk RUN=jre If the two variants I proposed this would be done as: USE_JAVA = jdk-jre or USE_JAVA = yes JAVA_BUILD = jdk JAVA_RUN = jre > Which means build dependency for the chosen JDK and run dependency for the > chosen JRE > > For devel/jakarta-ant: > USE_JAVA= RUN=JDK USE_JAVA = -jdk (no build required) or USE_JAVA = yes JAVA_RUN = jdk This example makes me want to choose the second version :). > Which means it builds without anything (JDK related I mean) as ant is > "install only" and need a JDK to run. > [snip] > > > I think we've got something here: use space separated preferences (in the > > > right order) for all JDK/JRE properties. So no more "+" (e.g. "1.3+") but > > > instead an explicit list of versions... > > > > I like the space separation :). However, I think the "+" sign is still > > useful as a short hand for 1.x 1.y ... 1.current. It also means we don't > > have to do a sweep when a new Java version comes out and add (for example) > > 1.5 to the list. I think for maximum flexibility and to preserve the > > usefulness of the "+" we should allow both a "+" and a space separated > > list. If the version is written with a "+" it must be the only version, > > i.e. you can't have "1.1 1.3+" as a list. > > That's a good point. The "+" is still greatly needed. And may be overriden > by the bsd.java.mk: > > .if ${USE_JAVA_VERSION} == "1.3+" > USE_JAVA_VERSION= 1.3 1.2 1.1 > .endif > > So we need to update only bsd.java.mk when a new version of Java comes > out. Yes, exactly. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org