From owner-svn-src-all@freebsd.org Tue Jan 29 17:22:01 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14EA714C4BFC; Tue, 29 Jan 2019 17:22:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 84328909D4; Tue, 29 Jan 2019 17:22:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x530.google.com with SMTP id s198so9024927pgs.2; Tue, 29 Jan 2019 09:22:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Vp4l/K+Fnrb8e44iB/TiH9kTpIZXmGX+SUqaIprRB88=; b=ossRZMynZfe10b8zzNhavRzpXp54bf0qBKW6L6uKw82f8vWcGH2SQ31YyHxGOtOouU E3RcONx2Qld9fCWJmzwG6MX8sG7pJwKFdhKO6j+q5UsoZU8+LqC6UQ2MiLjYr8oywLxr 9WO02oZTc3JGy6Y13mP+vwemO0DEevSpzdeVob8qrxArxLA2lqyltH/Vyov9co9azZwV kNc1cwnubCC2Y6P3v5v5TqEMuiLPnnDetTCFO2XJsBE9etIKQtJ1dFnr7gfKS0C76WwG HWDP5JuQhjdcLVtXGEqgVTteCUypMXpVK/1zMd3/U/XXxthbKm5MBYt0t3Z/bv+a9TqZ lwrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Vp4l/K+Fnrb8e44iB/TiH9kTpIZXmGX+SUqaIprRB88=; b=FWbWV3VLqA3CW0p4GE/K1eOW/0+lng2W4ELmafwW+VuP3wEBN/2tPS6EqihpXMucva /RDP0BXBsYOnUQVK0kTbrlizicn62JW9+ZUziSC3uHje1XCtouSrlDjnGQbgYlDiS3Il 38OsOUNjUamoQ3PhrdUyQHYfx7fg3ENEqP8GVCks3f1JUw8aCdrZvK+2tn8V4XVY6P8G Cpr/7DhiDLKWGiQuPr6tx+Ma08WJ8Y5g/5+AIeeRSu1vDi5U+kH7jIggo5vxE2AxWe+I aThaug7KmwiAFEwkTQqjDJVfDgkahbusNZLZE0ys81VkOEGTkcMfytVr7PqzLpW+o/Vx xXsg== X-Gm-Message-State: AJcUukdmFqMvuakffSoiBRWiuVnk/SlN2SrMWc/MFicUZWqHklPyHxFg O62rDuimGRsA35Rl4KVp5v8c1LNk X-Google-Smtp-Source: ALg8bN4ahj9F2gvJI5yCwza5c8TExlbmvUotqVWOV9irrA/9Qi/7kZQztY/andcGcAxZpFdgS3wO3w== X-Received: by 2002:a62:a1a:: with SMTP id s26mr27237656pfi.31.1548782519100; Tue, 29 Jan 2019 09:21:59 -0800 (PST) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id w136sm54046911pfd.169.2019.01.29.09.21.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 09:21:58 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r343543 - head/sbin/bectl/tests From: Enji Cooper X-Mailer: iPhone Mail (16C104) In-Reply-To: Date: Tue, 29 Jan 2019 09:21:57 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <1BE1B458-7AEA-412F-AD52-1E5554080422@gmail.com> References: <201901290408.x0T48oJQ080243@repo.freebsd.org> <674E01AB-49C7-4B40-B2FD-6EB4AFEAB1FD@gmail.com> <5687EE07-74FB-4233-B51D-C8948641E8CB@gmail.com> To: Kyle Evans X-Rspamd-Queue-Id: 84328909D4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 17:22:01 -0000 > On Jan 29, 2019, at 09:10, Kyle Evans wrote: >=20 >> On Tue, Jan 29, 2019 at 10:55 AM Enji Cooper wrot= e: >>=20 >>=20 >>>> On Jan 29, 2019, at 08:39, Kyle Evans wrote: >>>>=20 >>>> On Tue, Jan 29, 2019 at 10:32 AM Enji Cooper wr= ote: >>>>=20 >>>>=20 >>>>>> On Jan 28, 2019, at 20:10, Kyle Evans wrote: >>>>>>=20 >>>>>> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans wrot= e: >>>>>>=20 >>>>>> Author: kevans >>>>>> Date: Tue Jan 29 04:08:49 2019 >>>>>> New Revision: 343543 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/343543 >>>>>>=20 >>>>>> Log: >>>>>> bectl(8) test: Force destroy the zpool in cleanup >>>>>>=20 >>>>>> This is a wild guess as to why bectl tests failed once upon a time in= CI, >>>>>> given no apparent way to see a transcript of cleanup routines with Ky= ua. The >>>>>> bectl tests construct a new, clean zpool for every test. The failure >>>>>> indicated was because of a mount that was leftover from a previous te= st, but >>>>>> the previous test had succeeded so it's not clear how the mount remai= ned >>>>>> leftover unless the `zpool get health ${pool}` had somehow failed. >>>>>>=20 >>>>>=20 >>>>> I left out: the tests are supposed to be constructed to clean up any >>>>> mounts that were left over in the course of the test, hence the >>>>> assumption that the failure lies in the cleanup. >>>>=20 >>>> Hi Kyle, >>>>=20 >>>> The tests use a deterministic zpool name defined locally (not globally)= , and will only destroy the zpool if =E2=80=9Czpool get health=E2=80=9D succ= eeds. >>>>=20 >>>> The tests will work the first time (when the zpool doesn=E2=80=99t exis= t), but I believe they=E2=80=99re actually introducing nondeterminism by acc= ident. I will propose a fix for this. >>>>=20 >>>> There=E2=80=99s a way to decipher why things failed from /var/log/messa= ges and kyua output. It=E2=80=99s just nontrivial to those who don=E2=80=99t= know what to look for. Can you please provide a failing ci run? >>>>=20 >>>=20 >>> Hi, >>>=20 >>> Thanks! Any help is appreciated -- my inquiry to -testing@ in response >>> to the weekly report where the failing test [1] was mentioned has been >>> met with silence. The failure is consistent in the i386-test job, but >>> amd64-test sees nothing of the sort (and neither does my local >>> testing). >>=20 >> Thanks for the reminder to rejoin that list. >>=20 >>> [1] https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/426/testRepor= t/sbin.bectl/bectl_test/bectl_mount/ >>=20 >> It=E2=80=99s pretty obvious from the above run what=E2=80=99s going on fr= om the output. A similarly named zpool (same prefix; suffixed with a 2) is b= eing matched by grep, even though the test sets up one with a suffix in the p= receding steps. >>=20 >=20 > Right- this is the part that makes sense to me. =3D) The 'default2' BE > is clearly a leftover from a previous test, but it should've been > unmounted in the process and the zpool cleaned up. >=20 > What's not clear is how the cleanup routine is failing; the `zpool get > health` shouldn't have any reason to fail (though I can't test it > here, apparently =3D() and `zpool destroy -f` should've unmounted this > BE even if that hadn't happened throughout the course of the test, but > the failure remains (even if probably incorrectly fixed) following the > above commit. >=20 > Setting the zpool name globally with a suffix unique to this test > would likely be a great idea -- I think there's something else going > on as well, though. My comment about the zpool name being defined locally to tests as opposed is= globally is probably what=E2=80=99s tripping you up. The cleanup function i= s not run in the same shell context as the test. > Thanks, >=20 > Kyle Evans