From nobody Wed Aug 13 04:14:46 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c1w4x3LF8z64rN9; Wed, 13 Aug 2025 04:14:57 +0000 (UTC) (envelope-from philip@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c1w4x2m2fz3BmT; Wed, 13 Aug 2025 04:14:57 +0000 (UTC) (envelope-from philip@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755058497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FFDZhlT5kc5046hrAwRcf7KiEtKXxOEU8Ag+Oy/X614=; b=aXuErTi+6p7iO4DGaThu6j/IPnteJ/yGKvwIY7zdCRF0QZQMNrvBNzvLTlXQbI8Ka3ACTA XunsjX0Jds6EvI0wXvIhT5Nd/5erldNrnAmfdzBfV9bQcDxccD4K/p2/kfXJMGt7LOk4t4 vsRqec/OY8NI8eRCyFSD6KVVOnLjtEuiZrzZwYQj54ENcrHVVd4E61vDzRVsQ8TR3D9Y68 vhOf7tj/uKdWukh2RrPg6cXPoi1Bw+1djSE4OD0gEEdzRQ9Kxo0Q0+9g1t0qpdZKPAmoeM fKA3j+/yCxcRKpdIy9hQMkLFOIuiokYcqseVpW+iX+31qtYkYFgKx/lZYEcpDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755058497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FFDZhlT5kc5046hrAwRcf7KiEtKXxOEU8Ag+Oy/X614=; b=Alusa/2srFwD9P7ZB1szoivj6hHJjUN8oPaBVLJvjK6LKt+NhzxVp8rCkB3ckFypkSulve /Ctviiqb2N96Smp0KT62HlmSQ88yJf0qlVHoMC8Pewu8/wwPD3bBx5mA+/6hMd0laHIp6m K+Fr+onPg1TDYPhqfNyg/jKnP7Dz6IlfdDCCxEaScsuRXMvkr2SPP3iUP14LPIaJvkMj3I ZjZrI1fn2jG2kNy6YIGNyIJCsCyk8s0W+0LP9uHqWFGyFHuiQFy/oQlAuXN5GmbbvfPwGJ gbpNYpq0TFdYfuzfkyhMBd1Cq8UBAZz1PQ2FuMIqICd+OQSdu0lJpPrBK1nr2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755058497; a=rsa-sha256; cv=none; b=b3LojHgjmYX/g8sMap1loqAe67LmODjUC6yP5KucZ5VNIjxZLgzkWBN87zREVOR/7UrwOt laww10NNk6G/PMCMeEt62HlSMZTDBGJexq0wOMEbT9IbTRZGrKi80ZcbX+q5vrRJXSdwVX 4JplRHHJgpprbMcNnuGilaQEKqF2BBsMyn26hT12wTb9uu+jNdtSiJOkt871WrLfgaI2g/ UgZE0W+RvUSSHxg/sTb810NavBPn5C27mcTEvSBX1i9EeCYQWd1VrnmlTUDs4b9Eu1rdk2 0k/P7oj/Ma10/26u2nyhBNE90TuKFTtoKU/TVHEcYEhq8Z78v8ldxmJ87W5iYA== Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com [103.168.172.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: philip/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c1w4x1mfCz122p; Wed, 13 Aug 2025 04:14:57 +0000 (UTC) (envelope-from philip@freebsd.org) Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 98FC7F40067; Wed, 13 Aug 2025 00:14:56 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Wed, 13 Aug 2025 00:14:56 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddufeejvddvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujghofgesthdtredttdervdenucfhrhhomheprfhhihhl ihhpucfrrggvphhsuceophhhihhlihhpsehfrhgvvggsshgurdhorhhgqeenucggtffrrg htthgvrhhnpeethfekfedvudeggedvudevjeekheefvdehtdffheduhedttedvffekveff jedtudenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehphhhilhhiphdomhgvshhmthhprghu thhhphgvrhhsohhnrghlihhthidqudduieeivdeivdegkedqvdefhedukedttdekqdhphh hilhhipheppehfrhgvvggsshgurdhorhhgsehtrhhouhgslhgvrdhishdpnhgspghrtghp thhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepkhgvvhgrnhhssehfrh gvvggsshgurdhorhhgpdhrtghpthhtohepshhrtgdqtghomhhmihhtthgvrhhssehfrhgv vggsshgurdhorhhgpdhrtghpthhtohepuggvvhdqtghomhhmihhtshdqshhrtgdqrghllh esfhhrvggvsghsugdrohhrghdprhgtphhtthhopeguvghvqdgtohhmmhhithhsqdhsrhgt qdhmrghinhesfhhrvggvsghsugdrohhrgh X-ME-Proxy: Feedback-ID: ia691475d:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Aug 2025 00:14:54 -0400 (EDT) Date: Wed, 13 Aug 2025 12:14:46 +0800 From: Philip Paeps To: Kyle Evans Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: babab49eee94 - main - chroot: don't setgroups() without -G having been specified Message-ID: Mail-Followup-To: Kyle Evans , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202508121230.57CCUuHn045783@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <202508121230.57CCUuHn045783@gitrepo.freebsd.org> X-PGP-Fingerprint: B851 CD3A C248 F2ED 3E2C C18C BB6D 8A14 AFE7 D96B X-Date: Today is Setting Orange, the 6th day of Bureaucracy in the YOLD 3191 X-Phase-of-Moon: The Moon is Waning Gibbous (82% of Full) X-Clacks-Overhead: GNU Terry Pratchett Organization: Happily Disorganized User-Agent: Mutt/2.2.14 (2025-02-20) On 2025-08-12 12:30:56 (+0000), Kyle Evans wrote: >The branch main has been updated by kevans: > >URL: https://cgit.FreeBSD.org/src/commit/?id=babab49eee9472f628d774996de13d13d296c8c0 > >commit babab49eee9472f628d774996de13d13d296c8c0 >Author: Kyle Evans >AuthorDate: 2025-08-12 12:14:38 +0000 >Commit: Kyle Evans >CommitDate: 2025-08-12 12:30:23 +0000 > > chroot: don't setgroups() without -G having been specified > > We previously would not have setgroups() at all, but now we would drop > our supplementary groups every time. This broke chroot -n, probably > among other things. We need tests here, but lets unbreak things first. > > A future change may try to setgroups(2) when -u is specified in addition > to -G, so predicate the call on gidlist and don't populate that without > a grouplist. > > PR: 288751 > Fixes: 48fd05999b0f ("chroot: don't clobber the egid [...]") Thank you! This made the FreeBSD-kmods builds happy again. :) Philip