From owner-freebsd-current@FreeBSD.ORG Tue Sep 22 14:53:01 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3EDB21065679 for ; Tue, 22 Sep 2009 14:53:01 +0000 (UTC) (envelope-from gaijin.k@gmail.com) Received: from mail-qy0-f192.google.com (mail-qy0-f192.google.com [209.85.221.192]) by mx1.freebsd.org (Postfix) with ESMTP id A3C378FC18 for ; Tue, 22 Sep 2009 14:53:00 +0000 (UTC) Received: by qyk30 with SMTP id 30so801237qyk.7 for ; Tue, 22 Sep 2009 07:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=h8H/1rshRtstnunpGXm/7a9fTiHSjUH5ep9SQhmPWbg=; b=bTn0+eGoeJhuqTNHkHOM5jZx1uYG7dPa0i5ue+YpT+IFJvp6MFW8BUYJC69smYl+Dn Y8jP8uUn7baLrZ6v1pjZzCtptAPv8zwhgpuy9FSUWr8tFYdusxlbfCUjXjfqmZey9+bR M+0KUFYDkEiEn/tuhfga06w27eak39FeSBlTo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=xREtH63+n2qc5lf0SDTIOnISfFSuJMp71+PCHYAijRck7ITIOlghAPjY9p6Ilc50rk 7mBivM8MkuBBdwgmikXM3CmZ538ncxFSE5ms4VCq4l3MILOWUwesQTc9KYqGBrmRMdqa 9GwjSI0TJnUkR+qy3ToQ76qq3ayHHI0+lTly8= Received: by 10.224.65.69 with SMTP id h5mr763960qai.190.1253631179817; Tue, 22 Sep 2009 07:52:59 -0700 (PDT) Received: from ?10.0.3.231? (pool-71-187-189-54.nwrknj.fios.verizon.net [71.187.189.54]) by mx.google.com with ESMTPS id 7sm202632qwb.34.2009.09.22.07.52.58 (version=SSLv3 cipher=RC4-MD5); Tue, 22 Sep 2009 07:52:59 -0700 (PDT) From: "Alexandre \"Sunny\" Kovalenko" To: Jaakko Heinonen In-Reply-To: <20090922115106.GA2856@a91-153-125-115.elisa-laajakaista.fi> References: <19e9a5dc0909202237g1295b6d9hf69012745009eef4@mail.gmail.com> <20090921105458.GA86764@melamine.cuivre.fr.eu.org> <20090922115106.GA2856@a91-153-125-115.elisa-laajakaista.fi> Content-Type: text/plain; charset="UTF-8" Date: Tue, 22 Sep 2009 10:52:49 -0400 Message-Id: <1253631169.7895.2.camel@RabbitsDen> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 8bit Cc: Warren Block , freebsd-current@freebsd.org, Gonzalo Nemmi , avg@FreeBSD.org, Thomas Quinot Subject: Re: core dump on kldload atapicam X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2009 14:53:01 -0000 On Tue, 2009-09-22 at 14:51 +0300, Jaakko Heinonen wrote: > On 2009-09-21, Warren Block wrote: > > >> I can confirm that .. kldload atapicam still results in a "Fatal trap 12: > > >> page fault while in kernel mode" on 8.0-RC1 > > The problem was introduced in r195534. Does the following patch work for > you? > > %%% > Index: sys/dev/ata/atapi-cam.c > =================================================================== > --- sys/dev/ata/atapi-cam.c (revision 197399) > +++ sys/dev/ata/atapi-cam.c (working copy) > @@ -418,8 +418,10 @@ atapi_action(struct cam_sim *sim, union > break; > } > } > - cpi->maxio = softc->ata_ch->dma.max_iosize ? > - softc->ata_ch->dma.max_iosize : DFLTPHYS; > + if (softc->ata_ch != NULL && softc->ata_ch->dma.max_iosize != 0) > + cpi->maxio = softc->ata_ch->dma.max_iosize; > + else > + cpi->maxio = DFLTPHYS; > ccb->ccb_h.status = CAM_REQ_CMP; > xpt_done(ccb); > return; > %%% > I can confirm that: a) problem still exists in r197402 b) your patch (hand-applied) fixes it. I have not done any extensive testing of the device apart from mounting, unmounting and ejecting /dev/cd0. Thank you very much for your help. -- Alexandre Kovalenko (Олександр Коваленко)