From owner-freebsd-arch Wed Sep 18 11:43:35 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAEDC37B401 for ; Wed, 18 Sep 2002 11:43:34 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE7DD43E75 for ; Wed, 18 Sep 2002 11:43:33 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g8IIhRtF005836; Wed, 18 Sep 2002 20:43:29 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Julian Elischer Cc: arch@freebsd.org Subject: Re: Trivial mbuf patch for review. In-Reply-To: Your message of "Wed, 18 Sep 2002 10:18:28 PDT." Date: Wed, 18 Sep 2002 20:43:27 +0200 Message-ID: <5835.1032374607@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , Jul ian Elischer writes: > > >On Wed, 18 Sep 2002, Poul-Henning Kamp wrote: > > >a fair idea.. >I think m_length could be a maco or an inline.... >It's hardly worth a function call.. On the other hand, as Bruce would probably put it: Only broken code which fails to keep properly track of lengths needs to all m_length() or m_fixhdr() in the first place. As I said in other email: I don't think there is a performance case to be made for inline, and macros are just plain ugly. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message