From owner-cvs-all Wed Mar 12 15:59:51 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB1CB37B404 for ; Wed, 12 Mar 2003 15:59:48 -0800 (PST) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 042B743FAF for ; Wed, 12 Mar 2003 15:59:47 -0800 (PST) (envelope-from silby@silby.com) Received: (qmail 65589 invoked from network); 12 Mar 2003 23:59:46 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 12 Mar 2003 23:59:46 -0000 X-pair-Authenticated: 209.68.2.70 Date: Wed, 12 Mar 2003 17:56:34 -0600 (CST) From: Mike Silbersack To: David Schultz Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h vm_pageout.c In-Reply-To: <200303122313.h2CNDHMU046431@repoman.freebsd.org> Message-ID: <20030312175458.J32334@odysseus.silby.com> References: <200303122313.h2CNDHMU046431@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Have you tested this well? I ask only because the last time I played around with the swap killing code, I noticed that it was very fragile. More specifically, the kill signal isn't actually read and the kill performed until the process is swapped in and ran. Hence, with a lot of processes, that could take longer than expected. If you have time, you might consider looking around to see if the kill can be made more immediate. Mike "Silby" Silbersack On Wed, 12 Mar 2003, David Schultz wrote: > das 2003/03/12 15:13:16 PST > > FreeBSD src repository > > Modified files: > sys/vm vm_map.c vm_map.h vm_pageout.c > Log: > - When the VM daemon is out of swap space and looking for a > process to kill, don't block on a map lock while holding the > process lock. Instead, skip processes whose map locks are held > and find something else to kill. > - Add vm_map_trylock_read() to support the above. > > Reviewed by: alc, mike (mentor) > > Revision Changes Path > 1.287 +13 -2 src/sys/vm/vm_map.c > 1.97 +3 -0 src/sys/vm/vm_map.h > 1.227 +7 -2 src/sys/vm/vm_pageout.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message