From owner-freebsd-current@FreeBSD.ORG  Wed Jul  4 19:59:43 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5914316A41F;
	Wed,  4 Jul 2007 19:59:43 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id C105813C480;
	Wed,  4 Jul 2007 19:59:42 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l64JxfoL035439;
	Wed, 4 Jul 2007 23:59:41 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru;
	s=default; t=1183579181; bh=tDxlx1MyD0FEb+4frwyqcp4viTrpi1G7q0jWCsv
	jflM=; l=716; h=Received:Date:From:To:Cc:Subject:Message-ID:
	Mail-Followup-To:References:MIME-Version:Content-Type:
	Content-Disposition:In-Reply-To:User-Agent; b=DeyR5iaLLnjmt89W1BUh
	zCs8soYXJKnvyorprB2S8P7egaGQQG3U+yZav8elcKu8p/Gpek8cnF3FgfTLTzJsmtN
	fRmSQpOiwzVK1lHizH2u8dBrdMGqK9xPVyuYzBmIU2UZsND7pFF1Jqxp01mCeZOiNAo
	DgARDN6qEmIr0jfto=
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id l64Jxead035437;
	Wed, 4 Jul 2007 23:59:40 +0400 (MSD) (envelope-from ache)
Date: Wed, 4 Jul 2007 23:59:39 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: "Sean C. Farley" <scf@FreeBSD.org>
Message-ID: <20070704195939.GA35302@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	"Sean C. Farley" <scf@FreeBSD.org>,
	Robert Watson <rwatson@FreeBSD.org>,
	freebsd-current <freebsd-current@FreeBSD.org>,
	Michal Mertl <mime@traveller.cz>
References: <1183557221.1799.16.camel@genius.i.cz>
	<20070704143642.GA31254@nagual.pp.ru>
	<20070704150312.GB31683@nagual.pp.ru>
	<20070704101026.O77978@thor.farley.org>
	<20070704173905.T67251@fledge.watson.org>
	<20070704121316.A77978@thor.farley.org>
	<20070704180000.GA34042@nagual.pp.ru>
	<20070704144159.X77978@thor.farley.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070704144159.X77978@thor.farley.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: freebsd-current <freebsd-current@FreeBSD.org>,
	Robert Watson <rwatson@FreeBSD.org>, Michal Mertl <mime@traveller.cz>
Subject: Re: Environment handling broken in /bin/sh with changes to
	{get,set,put}env()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2007 19:59:43 -0000

On Wed, Jul 04, 2007 at 02:47:50PM -0500, Sean C. Farley wrote:
> My only concern is with programs (i.e., su) that "clean" the environment
> after calling setenv(), putenv() or unsetenv().  I wrote a patch[1] (and
> test program) that checks for a change of the address that environ is
> pointing.  If it detects a change, it scraps all that it knows about
> environ (frees everything) and starts with the new environ.
> 
> Of course, the sh patch[2] is still needed.
> 
> Sean
>   1. http://www.farley.org/freebsd/tmp/setenv/clearenv/
>   2. http://www.farley.org/freebsd/tmp/setenv/sh.patch

Ah, good catch. I think this two needs to be commited ASAP to avoid
more people reports.

-- 
http://ache.pp.ru/