From owner-svn-src-all@FreeBSD.ORG  Tue Apr 21 10:54:48 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1EE59106566C;
	Tue, 21 Apr 2009 10:54:48 +0000 (UTC)
	(envelope-from cperciva@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C6B68FC1F;
	Tue, 21 Apr 2009 10:54:48 +0000 (UTC)
	(envelope-from cperciva@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3LAsloU080837;
	Tue, 21 Apr 2009 10:54:47 GMT
	(envelope-from cperciva@svn.freebsd.org)
Received: (from cperciva@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3LAsl5b080836;
	Tue, 21 Apr 2009 10:54:47 GMT
	(envelope-from cperciva@svn.freebsd.org)
Message-Id: <200904211054.n3LAsl5b080836@svn.freebsd.org>
From: Colin Percival <cperciva@FreeBSD.org>
Date: Tue, 21 Apr 2009 10:54:47 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-releng@freebsd.org
X-SVN-Group: releng
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r191353 - in releng/7.2/contrib/ntp: . ntpq
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2009 10:54:48 -0000

Author: cperciva
Date: Tue Apr 21 10:54:47 2009
New Revision: 191353
URL: http://svn.freebsd.org/changeset/base/191353

Log:
  MFH r191302: Fix a buffer overflow.
  
  For reasons of stack alignment, it does not appear that this is exploitable
  on any systems FreeBSD runs on, so this will not be getting a security
  advisory.
  
  Approved by:	re (kib)

Modified:
  releng/7.2/contrib/ntp/   (props changed)
  releng/7.2/contrib/ntp/ntpq/ntpq.c

Modified: releng/7.2/contrib/ntp/ntpq/ntpq.c
==============================================================================
--- releng/7.2/contrib/ntp/ntpq/ntpq.c	Tue Apr 21 10:51:22 2009	(r191352)
+++ releng/7.2/contrib/ntp/ntpq/ntpq.c	Tue Apr 21 10:54:47 2009	(r191353)
@@ -3185,9 +3185,9 @@ cookedprint(
 				if (!decodeuint(value, &uval))
 				    output_raw = '?';
 				else {
-					char b[10];
+					char b[12];
 
-					(void) sprintf(b, "%03lo", uval);
+					(void) snprintf(b, sizeof(b), "%03lo", uval);
 					output(fp, name, b);
 				}
 				break;