From owner-svn-src-projects@FreeBSD.ORG Sat Dec 15 11:49:32 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E33A144D; Sat, 15 Dec 2012 11:49:32 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id C864E8FC13; Sat, 15 Dec 2012 11:49:32 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qBFBnW9X054388; Sat, 15 Dec 2012 11:49:32 GMT (envelope-from mav@svn.freebsd.org) Received: (from mav@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id qBFBnWJR054387; Sat, 15 Dec 2012 11:49:32 GMT (envelope-from mav@svn.freebsd.org) Message-Id: <201212151149.qBFBnWJR054387@svn.freebsd.org> From: Alexander Motin Date: Sat, 15 Dec 2012 11:49:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r244254 - projects/calloutng/sys/dev/random X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2012 11:49:33 -0000 Author: mav Date: Sat Dec 15 11:49:32 2012 New Revision: 244254 URL: http://svnweb.freebsd.org/changeset/base/244254 Log: Specify that wakeup rate of 7.5-10Hz is OK for yarrow harvesting thread. Modified: projects/calloutng/sys/dev/random/randomdev_soft.c Modified: projects/calloutng/sys/dev/random/randomdev_soft.c ============================================================================== --- projects/calloutng/sys/dev/random/randomdev_soft.c Sat Dec 15 11:44:04 2012 (r244253) +++ projects/calloutng/sys/dev/random/randomdev_soft.c Sat Dec 15 11:49:32 2012 (r244254) @@ -242,10 +242,10 @@ random_kthread(void *arg __unused) local_count = 0; /* Process until told to stop */ + mtx_lock_spin(&harvest_mtx); for (; random_kthread_control >= 0;) { /* Cycle through all the entropy sources */ - mtx_lock_spin(&harvest_mtx); for (source = RANDOM_START; source < ENTROPYSOURCE; source++) { /* * Drain entropy source records into a thread-local @@ -270,7 +270,6 @@ random_kthread(void *arg __unused) emptyfifo.count += local_count; local_count = 0; } - mtx_unlock_spin(&harvest_mtx); KASSERT(local_count == 0, ("random_kthread: local_count %d", local_count)); @@ -283,9 +282,11 @@ random_kthread(void *arg __unused) random_kthread_control = 0; /* Work done, so don't belabour the issue */ - pause("-", hz / 10); + msleep_spin_flags(&random_kthread_control, &harvest_mtx, + "-", hz / 10, C_PRELSET(1)); } + mtx_unlock_spin(&harvest_mtx); random_set_wakeup_exit(&random_kthread_control); /* NOTREACHED */