Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Jan 2011 20:50:36 +0000
From:      Alexander Best <arundel@freebsd.org>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric <dim@FreeBSD.org>
Subject:   Re: svn commit: r216977 - in head/libexec/rtld-elf: amd64 i386
Message-ID:  <20110105205036.GA58175@freebsd.org>
In-Reply-To: <4D24CD98.9080906@FreeBSD.org>
References:  <201101042051.p04KpSGk054564@svn.freebsd.org> <20110105011635.GA4952@freebsd.org> <4D246444.1060904@FreeBSD.org> <20110105185944.GA30449@freebsd.org> <4D24CD98.9080906@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Qxx1br4bt0+wmkIi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed Jan  5 11, Doug Barton wrote:
> On 01/05/2011 10:59, Alexander Best wrote:
> 
> >judging from the discussion going on right now it seems those flags will be
> >grouped together to form a new variable. so things will probably change 
> >shortly
> >and fixing the order is probably not necessary.
> 
> Much better to fix the problem properly now than to rely on future work 
> that may or may not happen. I realize that you alluded to this later in 
> your message, but I think as a general principle this is worth reinforcing.

this patch should make all the -mno-* flags be sorted conistently.

cheers.
alex

> 
> >some people have proposed hacking into clang which i personally think is a 
> >very
> >bad idea. why not contact the clang developers? they might like the idea 
> >of a
> >switch disabling all advanced extensions for every architecture?
> 
> I agree with this. We have a very awkward situation right now with lots 
> of local hacks in our version of gcc that in an ideal world we would not 
> replicate with clang; particularly considering the much lower barrier to 
> entry when it comes to contributing things back.
> 
> 
> Doug
> 
> -- 
> 
> 	Nothin' ever doesn't change, but nothin' changes much.
> 			-- OK Go
> 
> 	Breadth of IT experience, and depth of knowledge in the DNS.
> 	Yours for the right price.  :)  http://SupersetSolutions.com/

-- 
a13x

--Qxx1br4bt0+wmkIi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="sse3.diff"

diff --git a/libexec/rtld-elf/amd64/Makefile.inc b/libexec/rtld-elf/amd64/Makefile.inc
index 7d68611..7528dbe 100644
--- a/libexec/rtld-elf/amd64/Makefile.inc
+++ b/libexec/rtld-elf/amd64/Makefile.inc
@@ -1,6 +1,6 @@
 # $FreeBSD$
 
-CFLAGS+=	-mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow -msoft-float
+CFLAGS+=	-mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -msoft-float
 # Uncomment this to build the dynamic linker as an executable instead
 # of a shared library:
 #LDSCRIPT=	${.CURDIR}/${MACHINE_CPUARCH}/elf_rtld.x
diff --git a/libexec/rtld-elf/i386/Makefile.inc b/libexec/rtld-elf/i386/Makefile.inc
index 7d68611..7528dbe 100644
--- a/libexec/rtld-elf/i386/Makefile.inc
+++ b/libexec/rtld-elf/i386/Makefile.inc
@@ -1,6 +1,6 @@
 # $FreeBSD$
 
-CFLAGS+=	-mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow -msoft-float
+CFLAGS+=	-mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -msoft-float
 # Uncomment this to build the dynamic linker as an executable instead
 # of a shared library:
 #LDSCRIPT=	${.CURDIR}/${MACHINE_CPUARCH}/elf_rtld.x
diff --git a/sys/conf/kern.mk b/sys/conf/kern.mk
index 4d8636c..61f814d 100644
--- a/sys/conf/kern.mk
+++ b/sys/conf/kern.mk
@@ -66,7 +66,7 @@ INLINE_LIMIT?=	15000
 #
 .if ${MACHINE_CPUARCH} == "amd64"
 CFLAGS+=	-mcmodel=kernel -mno-red-zone \
-		-mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow \
+		-mfpmath=387 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 \
 		-msoft-float -fno-asynchronous-unwind-tables
 INLINE_LIMIT?=	8000
 .endif

--Qxx1br4bt0+wmkIi--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110105205036.GA58175>