From nobody Wed Sep 27 23:03:37 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rwsbt31dNz4v6lV; Wed, 27 Sep 2023 23:03:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rwsbt1htlz4ZBY; Wed, 27 Sep 2023 23:03:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695855818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iuXQQGVdQ5erSn13TJF8jYLG3NJ6rpYKBBRmdj4Nmbw=; b=D47i+4cPZrOtH25cevhE6OW9Roo1/LErii6Cder0wrgP0hCu9RrMzg3tIV3ozp/JxFZC4E LTqqgwSZ5aGOI0oSlTlpw2/K2CYK5Ye4CloieO08WM+oUqeg5JeNTjtPQgWWLO/GGWSz5e HWxhkLpOwJAPyHyumHby1CzmsDAgebVyhxSkHHg9b+Ei0pcOYWOCRvrRmM5ZvqgxEjKS1z QHhZlpHJgZz+8pwh0FAnNmdszPN7Uy7f5qFYv+rHfisl7R7l4RGSXnbSZUywqTrZ90+km4 xfCDGo4UpR1Qlow1//NxEA70XFY0we2ER5THLp5SmisYYea/iUHP7wAAozYESg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695855818; a=rsa-sha256; cv=none; b=L4ggnySRsT1662gk5b28UgcdZUI+RbubRUP44G0srF7jIHAKKb/wPwfXhBmxHyAYHBSPFO HP+lxyAPuZES33anxRnfyNKbN3nKdAialqGn7PuGa4zY1Fcn0WJcFyW4EA5wkgJiAKEdQP Sa0B5VdpYhRm8hT1k/w9if91CrnJd2hx+piwQFTgfs0BOOriYYvX1UolVtiCu0OPnYCURM fyf1ZI43BNgPIcDpHvVnQ/EfM3EZEm0dPYPrJjk+YcEv+GUp3xgETVd/5Pat52Mcwu4C0Z mA5dC3+ZmFiUE/64700c2BUhYIiQSQwRVDcnmgDacg+RJmabYD4DKsTi3Eh8xg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695855818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iuXQQGVdQ5erSn13TJF8jYLG3NJ6rpYKBBRmdj4Nmbw=; b=rq/Jv4lqwAQyDBdpxd0KjIM3Mc6WYRNciI8spd8zyPx/LmfpPB3yfVK8+VBC3ZJ+X4ehR+ L6sjBhy/Vl/oW09pM3Cqh0rY2wr540Nu3hBObaOx6rb3WTvvhwZiONGHN/OHs6noSql07M gVxkcYD6lhHrB7S7UpUTIkW4aKySPPf+2/rfWnOIBPg33fSUkS78KndWjXVBTbW5Wt7T3x vnSGIGBADzlxE0t6LH6WRQkH218kzkKYOmsSfVHEHbN9iCrDxvs51uGarlsE1R9dznGx0+ AwtLEPC+6NbwkwP7hkIPeCSXPaaPTieUMxB57y0WjoQj49S8pbkdo4MmHRp7LQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rwsbt0dzvzxDr; Wed, 27 Sep 2023 23:03:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38RN3bRW040930; Wed, 27 Sep 2023 23:03:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38RN3bWw040927; Wed, 27 Sep 2023 23:03:37 GMT (envelope-from git) Date: Wed, 27 Sep 2023 23:03:37 GMT Message-Id: <202309272303.38RN3bWw040927@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 60c95af88f6a - main - makefs/zfs: Remove a nonsensical comment List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 60c95af88f6a63fb7c2c86c6ff9c18743f6bbf0d Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=60c95af88f6a63fb7c2c86c6ff9c18743f6bbf0d commit 60c95af88f6a63fb7c2c86c6ff9c18743f6bbf0d Author: Mark Johnston AuthorDate: 2023-09-27 22:21:37 +0000 Commit: Mark Johnston CommitDate: 2023-09-27 23:03:26 +0000 makefs/zfs: Remove a nonsensical comment When populating files, makefs needs to copy their contents into userspace in order to compute a checksum, so copy_file_range(2) is out of the question. Though, it could possibly be used when building other types of filesystems. MFC after: 1 week Sponsored by: The FreeBSD Foundation --- usr.sbin/makefs/zfs/fs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/usr.sbin/makefs/zfs/fs.c b/usr.sbin/makefs/zfs/fs.c index a4968d5f91e8..0d85ea8eb9d8 100644 --- a/usr.sbin/makefs/zfs/fs.c +++ b/usr.sbin/makefs/zfs/fs.c @@ -551,8 +551,6 @@ fs_populate_file(fsnode *cur, struct fs_populate_arg *arg) /* * Fill up our buffer, handling partial reads. - * - * It might be profitable to use copy_file_range(2) here. */ sofar = 0; target = MIN(size - foff, (off_t)bufsz);