From owner-cvs-all@FreeBSD.ORG  Mon Apr  2 17:38:04 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 249FD16A401;
	Mon,  2 Apr 2007 17:38:04 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C3FC13C43E;
	Mon,  2 Apr 2007 17:38:03 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id E3D561A4D8F; Mon,  2 Apr 2007 10:38:03 -0700 (PDT)
Date: Mon, 2 Apr 2007 10:38:03 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20070402173803.GV61362@elvis.mu.org>
References: <200703290211.l2T2BlHv081735@repoman.freebsd.org>
	<20070401104935.C75869@fledge.watson.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070401104935.C75869@fledge.watson.org>
User-Agent: Mutt/1.4.2.2i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Julian Elischer <julian@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/linux linux_file.c linux_util.h
	src/sys/i386/linux linux.h linux_dummy.c linux_proto.h
	linux_syscall.h linux_sysent.c syscalls.master
	src/sys/amd64/linux32 linux.h linux32_dummy.c linux32_proto.h ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2007 17:38:04 -0000

* Robert Watson <rwatson@FreeBSD.org> [070401 07:57] wrote:
> 
> On Thu, 29 Mar 2007, Julian Elischer wrote:
> 
> >julian      2007-03-29 02:11:46 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> >   sys/compat/linux     linux_file.c linux_util.h
> >   sys/i386/linux       linux.h linux_dummy.c linux_proto.h
> >                        linux_syscall.h linux_sysent.c
> >                        syscalls.master
> >   sys/amd64/linux32    linux.h linux32_dummy.c linux32_proto.h
> >                        linux32_syscall.h linux32_sysent.c
> >                        syscalls.master
> > Log:
> > Implement the openat() linux syscall
> > Submitted by:   Roman Divacky (rdivacky@)
> > MFC after:      2 weeks
> 
> The locking and reference counting in this patch is highly dubious; also, 
> vn_fullpath() should really not be used this way, as it fails whenever 
> vnodes fall out of the name cache or a file system doesn't use the 
> namecache (i.e., it is purely advisory).  If we're going to do openat() in 
> the Linux emulation layer, let's instead implement it properly in the 
> FreeBSD system call code as a first class service and then wrap it the way 
> we wrap other system calls. Please do not MFC this patch as-is.

While I really appreciate the work here, I do have to agree with
Robert, this should have been implemented in FreeBSD proper and then
wrapped in the emulation layer.

-- 
- Alfred Perlstein