From owner-freebsd-hackers Wed Mar 6 10:40:11 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 2C2F437B404 for ; Wed, 6 Mar 2002 10:40:00 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id g26IdwOJ037134; Wed, 6 Mar 2002 13:39:58 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <15493.62234.943657.776598@guru.mired.org> References: <15493.61384.557931.883967@guru.mired.org> <30203.1015411062@critter.freebsd.dk> <15493.62234.943657.776598@guru.mired.org> Date: Wed, 6 Mar 2002 13:39:56 -0500 To: "Mike Meyer" , Poul-Henning Kamp From: Garance A Drosihn Subject: Re: RFC: style(9) isn't explicit about booleans for testing. Cc: hackers@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In one message, At 12:52 AM -0800 3/6/02, David O'Brien wrote: >I don't think it is clarifying a rule. I think it is in fact adding >a rule. You are extrapolating too much I think. All the rule is >trying to prevent is "if (!strcmp(a,b))" which when read is extremely >wrong of that is actually happening. In a later message (not directly replying to the above), At 4:44 AM -0600 3/6/02, Mike Meyer wrote: >Looking at the text in the page on -stable, I think the one-word >change from boolean to "integer" would remove the ambiguity. If we change boolean to integer, then the proposed rule will not prevent "if (!strcmp(a,b))" , because strcmp() *does* return an integer value. Or am I missing something here? -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message