From owner-freebsd-sysinstall@FreeBSD.ORG Sat Mar 22 14:55:57 2014 Return-Path: Delivered-To: sysinstall@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B9A62F2D; Sat, 22 Mar 2014 14:55:57 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6596A627; Sat, 22 Mar 2014 14:55:53 +0000 (UTC) Received: from smarthost.fisglobal.com ([10.132.206.192]) by ltcfislmsgpa04.fnfis.com (8.14.5/8.14.5) with ESMTP id s2MEtppr007527 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 22 Mar 2014 09:55:52 -0500 Received: from THEMADHATTER (10.242.181.54) by smarthost.fisglobal.com (10.132.206.192) with Microsoft SMTP Server id 14.3.174.1; Sat, 22 Mar 2014 09:55:50 -0500 From: Sender: Devin Teske To: "'Bryan Drewery'" References: <532D84AF.5080506@FreeBSD.org> In-Reply-To: <532D84AF.5080506@FreeBSD.org> Subject: RE: bsdinstall ZFS /root in wrong dataset Date: Sat, 22 Mar 2014 07:55:36 -0700 Message-ID: <010101cf45de$c9707380$5c515a80$@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQHLz5xmDx81IywBvK/rXThmV93ImZr0HRHQ Content-Language: en-us X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.87, 1.0.14, 0.0.0000 definitions=2014-03-22_01:2014-03-21,2014-03-22,1970-01-01 signatures=0 Cc: sysinstall@FreeBSD.org X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Mar 2014 14:55:57 -0000 > -----Original Message----- > From: Bryan Drewery [mailto:bdrewery@FreeBSD.org] > Sent: Saturday, March 22, 2014 5:40 AM > To: sysinstall@FreeBSD.org > Subject: bsdinstall ZFS /root in wrong dataset > > (I am not subscribed so please CC me) > > The ZFS layout uses the zroot/ROOT/ to support boot environments. > The problem with it is that /root is part of the BE. Home directories are > properly outside of the BE. > > /root should really be outside to persist history and other changes to root's > homedir through BE changes/upgrades. > > This is quite noticeable if you create a new BE (beadm create; beadm > mount) and then installworld/kernel into it, then activate and reboot. > All of your history and /root changes are missing for the period between > creating the BE and rebooting. > > Something like this is needed: > > > --- usr.sbin/bsdinstall/scripts/zfsboot (revision 263620) > > +++ usr.sbin/bsdinstall/scripts/zfsboot (working copy) > > @@ -128,6 +128,8 @@ > > > > # Home directories separated so they are common to all BEs > > /usr/home # NB: /home is a symlink to /usr/home > > + /root mountpoint=/root > > > > # Ports tree > > /usr/ports compression=lz4,setuid=off > > > Though, I am unsure on whether we should make a zroot/root dataset and > mount it in or mkdir /usr/home/root and symlink /root to it. The symlink > does cause mergemaster confusion though. I have no opinion on where we > create the root dataset, as long as it is outside of ROOT. > Hi bdrewery, Thanks for kicking off this thread (esp. on list). Placing /root in /usr/home/root would break in a few scenarios as you correctly identified. Let's give your patch a go and wait for some feedback before MFC'ing. I don't expect any fallout from your patch; looks great and indeed should solve the problem (if I understand correctly). Do you want to commit or should I? -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.