From owner-svn-src-all@freebsd.org Mon Dec 28 03:45:08 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42A68A52299 for ; Mon, 28 Dec 2015 03:45:08 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com [209.85.217.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D87A11E98 for ; Mon, 28 Dec 2015 03:45:07 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lb0-f172.google.com with SMTP id oh2so86365685lbb.3 for ; Sun, 27 Dec 2015 19:45:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=fvb8vcSHtdCggwOgOQODgtq5JOVm5ivKjpuOO0ErXEI=; b=An6G1h5Vo0QREGxjFWJ+PL6kMts/ytunQN+s9EPnEpUGkH4Q82YyeJvYTpAsT//F3w Mi9PRrKbC4cYe34Y0xZEpzS/bUtaV2Fjq4jFHyUcuGbsnZV0wArVl7UKxVyzVK39XMV3 ryRY8CowxNaveR+kA32HtiAZOOf5JcSLYu+/8ecHbRwIOnsGtOosSxnTf6oNtUGDhHS+ YXXyEgmcAefLhoAT6f26I9/W7uQ+IxG3S38xBQiFdDKkfUWv0aw1S8ue+go2se84wMaK SY97EVC2A/SlE/RJKgkXkQYK/nN/bryi5aQfU7y1svY3/kYopSc1eoLl6FbliZ35qpVq FteA== X-Gm-Message-State: ALoCoQlVXtsNUP28Wz8eIRBAFx8GLFJ0xd/nTDslV8aUKNPDEYxeOR3YkNnfb3Jkj5bQ20U55B6GPGCp9g5IZKX45oG+QJfLew== X-Received: by 10.112.140.166 with SMTP id rh6mr18488828lbb.77.1451274306047; Sun, 27 Dec 2015 19:45:06 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id q8sm10112173lbr.1.2015.12.27.19.45.05 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 27 Dec 2015 19:45:05 -0800 (PST) Subject: Re: svn commit: r292823 - in stable/10/sys: conf netinet To: Patrick Kelsey References: <201512280243.tBS2hD7X008202@repo.freebsd.org> <5680A574.9050002@freebsd.org> <5680A991.5040301@freebsd.org> <0087B045-F70E-4CF5-A1B7-5B421926BB5A@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org From: Andrey Chernov Message-ID: <5680B040.40106@freebsd.org> Date: Mon, 28 Dec 2015 06:45:04 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <0087B045-F70E-4CF5-A1B7-5B421926BB5A@freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2015 03:45:08 -0000 On 28.12.2015 6:36, Patrick Kelsey wrote: > > >> On Dec 27, 2015, at 10:16 PM, Andrey Chernov wrote: >> >>> On 28.12.2015 5:59, Andrey Chernov wrote: >>>> On 28.12.2015 5:43, Patrick Kelsey wrote: >>>> Author: pkelsey >>>> Date: Mon Dec 28 02:43:12 2015 >>>> New Revision: 292823 >>>> URL: https://svnweb.freebsd.org/changeset/base/292823 >>>> >>>> Log: >>>> MFC r292706: >>>> >>>> Implementation of server-side TCP Fast Open (TFO) [RFC7413]. >>>> >>>> TFO is disabled by default in the kernel build. See the top comment >>>> in sys/netinet/tcp_fastopen.c for implementation particulars. >>> >>> Why it is disabled by default? Do we need some rc.conf knobs to not deal >>> directly with it, like tcp_extensions? OMG, why it is kernel config and >>> not boot-time sysctl? >> >> BTW, TCP_RFC7413_MAX_KEYS currently unused and I have no clues what it >> supposed to be. I can't find it in the phabric patch at all. >> > > Look at line 127 in tcp_fastopen.c. Also, read the top comment in tcp_fastopen.c. > > Phabricator is buggy and unreliable, and using it as a primary reference to the code will let you down as it has let me down, repeatedly. For example, it will not show you the contents of entirely new files unless you manually upload them - I believe this what is currently affecting your viewpoint. Ok, thanx, I see now, sorry phabricator confuses me at this point. Someone should fix it to avoid such things. -- http://ache.vniz.net/