From owner-cvs-all Mon Apr 8 21: 1:58 2002 Delivered-To: cvs-all@freebsd.org Received: from obsecurity.dyndns.org (adsl-64-169-104-17.dsl.lsan03.pacbell.net [64.169.104.17]) by hub.freebsd.org (Postfix) with ESMTP id E506237B419; Mon, 8 Apr 2002 21:01:51 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 6E67666CFD; Mon, 8 Apr 2002 21:01:51 -0700 (PDT) Date: Mon, 8 Apr 2002 21:01:51 -0700 From: Kris Kennaway To: John Baldwin Cc: Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" Subject: Re: cvs commit: src/sys/sys ioccom.h Message-ID: <20020408210151.B18407@xor.obsecurity.org> References: <20020408205017.A18187@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="mojUlQ0s9EVzWg2t" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from jhb@FreeBSD.org on Mon, Apr 08, 2002 at 11:51:50PM -0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --mojUlQ0s9EVzWg2t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2002 at 11:51:50PM -0400, John Baldwin wrote: >=20 > On 09-Apr-2002 Kris Kennaway wrote: > > On Mon, Apr 08, 2002 at 11:39:52PM -0400, John Baldwin wrote: > >>=20 > >> On 09-Apr-2002 David E. O'Brien wrote: > >> > obrien 2002/04/08 19:22:14 PDT > >> >=20 > >> > Modified files: > >> > sys/sys ioccom.h=20 > >> > Log: > >> > Back out revision 1.11 which wrapped the ioctl prototype w/()'s. > >> > While it may have allowed the XFree86 4 port to build; it killed T= ONS > >> > of other ports. The XFree86 4 can be patched to not use its macro= a lot > >> > easier than figuring how to deal with 1000 other now-broken ports. > >>=20 > >> Actually, that isn't correct. For example, when compiling screen on my > >> ultra60, it whined because the auto* tools in their infinite wisdom (o= r lack > >> thereof) define ioctl as so in osdef.h: > >>=20 > >> extern int ioctl __P((int, int, char *)); > >=20 > > That's a hardcoded prototype in the screen source code, not something > > auto-generated by autoconf. Furthermore, screen seems to hard-code > > prototypes for *every* standard function instead of using the system > > headers. I fixed up these to use #includes, but screen also tries to > > redefine structures defined in the system headers so it's still badly > > broken. >=20 > screen used to compile. :-P Was this broken in a recent upgrade that no = one > bothered to check or something? It was broken by r1.11 of ioccom.h as stated, AFAICT. gcc apparently treats ioctl() and (ioctl)() as different prototypes. Kris --mojUlQ0s9EVzWg2t Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE8smeuWry0BWjoQKURAhqDAKCvu68FwmhmZpJGDN6C7doq6r0W8wCg480G 6XvOjgj8bpzW3IZfmW63cHQ= =1Unw -----END PGP SIGNATURE----- --mojUlQ0s9EVzWg2t-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message