From owner-freebsd-current@FreeBSD.ORG Mon Sep 20 21:35:03 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 00A1816A4CE; Mon, 20 Sep 2004 21:35:03 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0E0D43D2F; Mon, 20 Sep 2004 21:35:02 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-127-84-57.dsl.snfc21.pacbell.net [67.127.84.57]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i8KLYuDl011345; Mon, 20 Sep 2004 14:34:56 -0700 Message-ID: <414F4CF2.2050404@root.org> Date: Mon, 20 Sep 2004 14:34:42 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <41421D6A.8070805@cronyx.ru> <414E7581.2070505@root.org> <414F256B.1030304@cronyx.ru> <200409201652.24457.jhb@FreeBSD.org> In-Reply-To: <200409201652.24457.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: FreeBSD Current cc: Roman Kurakin Subject: Re: mp_machdep.c (was Re: [Fwd: Re: Bug reports requested - acpi]) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 21:35:03 -0000 John Baldwin wrote: > It's probably cleaner to use pmap_invalidate_range(). Something like: > > Index: mp_machdep.c > =================================================================== > RCS file: /usr/cvs/src/sys/i386/i386/mp_machdep.c,v > retrieving revision 1.238 > diff -u -r1.238 mp_machdep.c > --- mp_machdep.c 1 Sep 2004 06:42:01 -0000 1.238 > +++ mp_machdep.c 20 Sep 2004 20:50:35 -0000 > @@ -738,15 +738,19 @@ > int x; > int size = *(int *) ((u_long) & bootMP_size); > u_char *src = (u_char *) ((u_long) bootMP); > - u_char *dst = (u_char *) boot_address + KERNBASE; > + u_char *dst; > u_int boot_base = (u_int) bootMP; > u_int8_t *dst8; > u_int16_t *dst16; > u_int32_t *dst32; > + vm_offset_t va; > > POSTCODE(INSTALL_AP_TRAMP_POST); > > - pmap_kenter(boot_address + KERNBASE, boot_address); > + va = boot_address + KERNBASE; > + pmap_kenter(va, boot_address); > + pmap_invalidate_range(kernel_pmap, va, va + size); > + dst = (u_char *)va; > for (x = 0; x < size; ++x) > *dst++ = *src++; > > It seems odd that this is needed though. Does it go away if you use > DISABLE_PSE or DISABLE_PGE? He's on a Pentium 2 or something. -- Nate