From owner-freebsd-toolchain@FreeBSD.ORG  Fri Apr 17 14:06:29 2015
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: freebsd-toolchain@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A74E1858
 for <freebsd-toolchain@freebsd.org>; Fri, 17 Apr 2015 14:06:29 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8D092793
 for <freebsd-toolchain@freebsd.org>; Fri, 17 Apr 2015 14:06:29 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t3HE6Tho003395
 for <freebsd-toolchain@freebsd.org>; Fri, 17 Apr 2015 14:06:29 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HE6TfH003394;
 Fri, 17 Apr 2015 14:06:29 GMT (envelope-from root)
Date: Fri, 17 Apr 2015 14:06:29 +0000
To: freebsd-toolchain@freebsd.org
From: "imp (Warner Losh)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Updated] D2305: Fix bootstraping of crunchide
Message-ID: <5aad4c0f25ac29184d5bf730516ecddf@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2305: Fix bootstraping of crunchide
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-MLST-i5ptaleg3lqtvx7cknno>
In-Reply-To: <differential-rev-PHID-DREV-3zy3ok425s65douldd7j-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-3zy3ok425s65douldd7j-req@FreeBSD.org>
Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxE2U=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Apr 2015 14:06:29 -0000

imp added a comment.

I think that we've stumbled on more stuff we can just kill :)

INLINE COMMENTS
  Makefile.inc1:1469 I'd be inclined to promote it.
  Makefile.inc1:1470 Can you tell me where in the tree we define RELEASEDIR? Is it still even a thing?
  
  Makefile.inc1:1475 I'd love to know why this is needed.
  
  (1) It is tiny, so building on 386 is fine, and the next line catches it.
  (2) Cross building, the next line would catch it.
  
  Makefile.inc1:1476 Not withstanding my silly nitpicking above, I think this whole thing can be removed.
  RELEASEDIR isn't defined anywhere
  grep -r kgzip shows this is the only place that we build it or reference it in the tree
  Therefore, since the witch weights the same as a duck, it is deadwood and can be burned.

REVISION DETAIL
  https://reviews.freebsd.org/D2305

To: rodrigc, emaste, imp
Cc: freebsd-toolchain