From owner-freebsd-fs@FreeBSD.ORG  Wed Aug  1 14:15:24 2012
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 683DE106564A
	for <freebsd-fs@freebsd.org>; Wed,  1 Aug 2012 14:15:24 +0000 (UTC)
	(envelope-from andrey@zonov.org)
Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54])
	by mx1.freebsd.org (Postfix) with ESMTP id E1D808FC12
	for <freebsd-fs@freebsd.org>; Wed,  1 Aug 2012 14:15:23 +0000 (UTC)
Received: by eeke52 with SMTP id e52so2035560eek.13
	for <freebsd-fs@freebsd.org>; Wed, 01 Aug 2012 07:15:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:subject
	:content-type:content-transfer-encoding:x-gm-message-state;
	bh=TXrDUDEPfWg2hcoZUFm5RtDF3VTSp6+jEYlZyfjrHPo=;
	b=AvocCvSSXnz+8pOdbOk1skLQdCba4lQ+Buvp9EWdAnbqaeUS3eXexqja6cpF3cz9xl
	mWBwl7NHsKLDQDtNmhBZ8ncMG/GQIeiaGvOsIFEdFKfjm/4xwsPIH4lTWtBG6VczpPfI
	TVCg38ubb7sfoO0aCO0y/AyDjN1NAGwJsrgcTh6wi4qwZZMyA6pXm8cSdZV0ui0TUomv
	ZRE6+g8bvn6zef1Z/ZjxIsNkUiAmwBdAyOzFa8EzjE27t//0mAT4LfinEW/ru0WS6wxu
	01/MegKWrly+CkBW/+1hErLJGOpnuQv/ZOxlFVceLkd+mGVZZJULwPxu0d/Q2E9YPNFV
	TYsQ==
Received: by 10.14.210.132 with SMTP id u4mr21972392eeo.6.1343830522668;
	Wed, 01 Aug 2012 07:15:22 -0700 (PDT)
Received: from dhcp170-243-red.yandex.net
	([2a02:6b8:0:401:ac75:9216:41ce:82d3])
	by mx.google.com with ESMTPS id v5sm9292770eel.6.2012.08.01.07.15.21
	(version=SSLv3 cipher=OTHER); Wed, 01 Aug 2012 07:15:22 -0700 (PDT)
Message-ID: <501939F8.7070006@zonov.org>
Date: Wed, 01 Aug 2012 18:15:20 +0400
From: Andrey Zonov <andrey@zonov.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
	rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: freebsd-fs@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQnJ1WLpVAfLm9emV3sKmIu7OvT8ZqsWtafIEP/Pj+3OGoiufZ1yPJpbznUqqeLow0JyYycS
Subject: remove check for SUJ_MAX from fsck_ffs(8)
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2012 14:15:24 -0000

Hi,

It's possible to set any size for SU journal not less than 4Mb with 
tunefs(8), but fsck_ffs(8) reports that it could not check such FS 
because "Invalid size".  It seems that fsck_ffs should not check maximum 
size of journal.

I suggest that patch:

Index: sbin/fsck_ffs/suj.c
===================================================================
--- sbin/fsck_ffs/suj.c	(revision 238945)
+++ sbin/fsck_ffs/suj.c	(working copy)
@@ -2383,7 +2383,7 @@ suj_verifyino(union dinode *ip)
  		return (-1);
  	}

-	if (DIP(ip, di_size) < SUJ_MIN || DIP(ip, di_size) > SUJ_MAX) {
+	if (DIP(ip, di_size) < SUJ_MIN) {
  		printf("Invalid size %jd for journal inode %d\n",
  		    DIP(ip, di_size), sujino);
  		return (-1);

What do you think?

-- 
Andrey Zonov