From owner-cvs-all@FreeBSD.ORG Wed Aug 4 13:21:16 2010 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FD73106567E; Wed, 4 Aug 2010 13:21:16 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id F393C8FC21; Wed, 4 Aug 2010 13:21:14 +0000 (UTC) Received: by wyj26 with SMTP id 26so6774630wyj.13 for ; Wed, 04 Aug 2010 06:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=uvnV4n9W0xFr4u4HInqbNtdf9G0LESp6KQjy30r9vlI=; b=k/CNB7HZ9u8iZCw76aF2qIAUVw7guDQ0HsFU580Y3NTPwsn+pJbKQ3MuwkPMU2iqvf TDY8YOnKnwMvTz7tOAE5e+i0/zbUqqUFd7FylU7wUopyvwRXGyH0s7CTFaMZFt/eg5wa RJE3roAGGFAlGb/q3HinhbdiNbnyuzvYA2fnQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=x+BCLhbYCkXQO4nnBy/EBgpurfOBvmUJEfjf9cnMwjFj4pJGxogt1pNqn9oBhdmrza J45fsYPQ3/2D8aFWtqsMF3HYkXwgliyLoPywRt7oWW7DfpWeN17skpaum+41ypfvUVne HFATViOTTAR7Ql+s0EWByBTltgGPleLkYBQ3g= MIME-Version: 1.0 Received: by 10.216.10.145 with SMTP id 17mr7705682wev.27.1280928060438; Wed, 04 Aug 2010 06:21:00 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.216.238.16 with HTTP; Wed, 4 Aug 2010 06:21:00 -0700 (PDT) In-Reply-To: References: <200711142121.lAELLmo4018474@repoman.freebsd.org> Date: Wed, 4 Aug 2010 15:21:00 +0200 X-Google-Sender-Auth: cIg_Za3PLiUjVB_afbDrIudGrqc Message-ID: From: Attilio Rao To: Robert Watson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, alfred@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_rwlock.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2010 13:21:16 -0000 2010/8/4 Attilio Rao : > 2010/8/4 Robert Watson : >> On Wed, 14 Nov 2007, Attilio Rao wrote: >> >>> attilio =C2=A0 =C2=A0 2007-11-14 21:21:48 UTC >>> >>> =C2=A0FreeBSD src repository >>> >>> =C2=A0Modified files: >>> =C2=A0 sys/kern =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kern_rwlock.c >>> =C2=A0Log: >>> =C2=A0Remove a bogus KASSERT which will prevent rwlock to be acquired >>> =C2=A0recursively in exclusive mode with debugging kernels. >>> >>> =C2=A0Submitted by: kmacy >>> =C2=A0Approved by: jeff >>> >>> =C2=A0Revision =C2=A0Changes =C2=A0 =C2=A0Path >>> =C2=A01.30 =C2=A0 =C2=A0 =C2=A0+0 -3 =C2=A0 =C2=A0 =C2=A0src/sys/kern/k= ern_rwlock.c >> >> Hi Attilio-- >> >> This bug seems also to affect the 6.x backport of rwlocks that Alfred di= d. >> Might either you or Alfred consider doing an MFC of this change? =C2=A0W= ithout >> it, recursive write locks on rwlocks are broken with INVARIANTS enabled. > > Thanks for signaling this, I'll take care. r210844 may have fixed this. Thanks, Attilio --=20 Peace can only be achieved by understanding - A. Einstein