From nobody Wed Aug 20 09:38:15 2025
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c6Lwz3vvkz64gFY;
	Wed, 20 Aug 2025 09:38:27 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4c6Lwz0ffYz3s1h;
	Wed, 20 Aug 2025 09:38:26 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Authentication-Results: mx1.freebsd.org;
	none
Received: from tom.home (kib@localhost [127.0.0.1] (may be forged))
	by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 57K9cFC0038789;
	Wed, 20 Aug 2025 12:38:18 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 57K9cFC0038789
Received: (from kostik@localhost)
	by tom.home (8.18.1/8.18.1/Submit) id 57K9cFY6038786;
	Wed, 20 Aug 2025 12:38:15 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f
Date: Wed, 20 Aug 2025 12:38:15 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@freebsd.org>
Cc: Aymeric Wibo <obiwac@freebsd.org>, src-committers@freebsd.org,
        dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject: Re: git: 75acf71786f2 - main - libifconfig: Remove ifconfig_set_fib
 and ifconfig_sfp_id_is_qsfp
Message-ID: <aKWXh6JPXavV2ZJq@kib.kiev.ua>
References: <202508192309.57JN9cNK038457@gitrepo.freebsd.org>
 <aKWDR0OPh_NbwEIK@kib.kiev.ua>
 <868qjejqdb.fsf@ltc.des.dev>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
X-BeenThere: dev-commits-src-all@freebsd.org
Sender: owner-dev-commits-src-all@FreeBSD.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <868qjejqdb.fsf@ltc.des.dev>
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
	NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1
X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Rspamd-Queue-Id: 4c6Lwz0ffYz3s1h

On Wed, Aug 20, 2025 at 11:26:24AM +0200, Dag-Erling Smørgrav wrote:
> Konstantin Belousov <kostikbel@gmail.com> writes:
> > Aymeric Wibo <obiwac@freebsd.org> writes:
> >>     libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp
> > This breaks the ABI, of course.
> 
> No, it does not.  Please take the time to check before throwing
> accusations around.

If a symbol is removed from the library export list, its ABI is broken.

If a symbol was not present in the object but it is listed in the version
script, then the build is broken (ld.lld --no-undefined-version was missed).