From owner-cvs-all Thu May 11 11:52:48 2000 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (peter1.yahoo.com [208.48.107.4]) by hub.freebsd.org (Postfix) with ESMTP id F21B337BC41; Thu, 11 May 2000 11:52:33 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 13AE51CD7; Thu, 11 May 2000 11:32:43 -0700 (PDT) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: nate@yogotech.com (Nate Williams) Cc: Garrett Wollman , Greg Lehey , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/vinum list.c In-Reply-To: Message from Nate Williams of "Thu, 11 May 2000 09:48:40 MDT." <200005111548.JAA17793@nomad.yogotech.com> Date: Thu, 11 May 2000 11:32:43 -0700 From: Peter Wemm Message-Id: <20000511183243.13AE51CD7@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Nate Williams wrote: > > < s aid: > > > > > Revision Changes Path > > > 1.27 +12 -17 src/sbin/vinum/list.c > > > > > Revision Changes Path > > > 1.34 +43 -40 src/sbin/vinum/vinum.8 > > > > [...] > > > > Could you PLEASE batch your commits like everybody else? > > I actually prefer Greg's way of doing things. It's more email, but > email is trivial to delete, and when you go look at things in the logs, > it's much easier to figure out what's happening. Likewise. When people ask me, I encourage them to make seperate discrete commits where it makes sense to have accurate logs for the files affected by the changes. Jumbo-commits where 500 files are affected with 500 different changes are clearly suboptimal as all 500 change descriptions end up in 500 rcs files, instead of 1 change description in each of the 500 files. The commit mail isn't as much of a problem compared to doing a 'cvs log' and getting a small essay on the a commit that turns out to be a typo correction in this particular file. People should use their judgement to strike a balance between descriptive logs describing an atomic change group over multiple files in a single commit versus having each file getting an accurate standalone change log. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message