From owner-svn-ports-all@FreeBSD.ORG Sun Nov 3 19:48:50 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E82549FF; Sun, 3 Nov 2013 19:48:50 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay005.isp.belgacom.be (mailrelay005.isp.belgacom.be [195.238.6.171]) by mx1.freebsd.org (Postfix) with ESMTP id C259D2EDE; Sun, 3 Nov 2013 19:48:49 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlUGAJKndlJbs76w/2dsb2JhbABZgwc4R79agRoXdIIlAQEFOhwjEAsUBAklDyoeBogYAQi9M48lMweELgOYCYEwkFqDJzs Received: from 176.190-179-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.179.190.176]) by relay.skynet.be with ESMTP; 03 Nov 2013 20:48:43 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id rA3JmgVc012167; Sun, 3 Nov 2013 20:48:42 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Sun, 3 Nov 2013 20:48:42 +0100 From: Tijl Coosemans To: Danilo Egea Gondolfo Subject: Re: svn commit: r332635 - head/lang/yap/files Message-ID: <20131103204842.20bc5aa7@kalimero.tijl.coosemans.org> In-Reply-To: <201311031811.rA3IBULH080088@svn.freebsd.org> References: <201311031811.rA3IBULH080088@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Nov 2013 19:48:51 -0000 On Sun, 3 Nov 2013 18:11:30 +0000 (UTC) Danilo Egea Gondolfo wrote: > Author: danilo > Date: Sun Nov 3 18:11:29 2013 > New Revision: 332635 > URL: http://svnweb.freebsd.org/changeset/ports/332635 > > Log: > - Fix build with clang on i386 > > Added: > head/lang/yap/files/patch-H__absmi.h (contents, props changed) > Modified: > head/lang/yap/files/patch-library__dialect__swi__fli__blobs.c > head/lang/yap/files/patch-packages__swi-minisat2__C__SolverTypes.h > > Added: head/lang/yap/files/patch-H__absmi.h > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/lang/yap/files/patch-H__absmi.h Sun Nov 3 18:11:29 2013 (r332635) > @@ -0,0 +1,11 @@ > +--- ./H/absmi.h.orig 2013-11-02 21:11:04.000000000 -0200 > ++++ ./H/absmi.h 2013-11-02 21:11:12.000000000 -0200 > +@@ -74,7 +74,7 @@ > + * Use bp as PREG for X86 machines * > + ***************************************************************/ > + #if defined(IN_ABSMI_C) > +-register struct yami* P1REG asm ("bp"); /* can't use yamop before Yap.h */ > ++struct yami* P1REG asm ("bp"); /* can't use yamop before Yap.h */ Have you runtested this? Because this expects the ebp register to hold the value of P1REG and this change does not guarantee that. Clang does not support global register variables at all so if you cannot disable this code it has to be compiled with gcc.