From owner-freebsd-current Thu Mar 7 19:15:31 2002 Delivered-To: freebsd-current@freebsd.org Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122]) by hub.freebsd.org (Postfix) with ESMTP id E103A37B402 for ; Thu, 7 Mar 2002 19:15:27 -0800 (PST) Received: (from mike@localhost) by espresso.q9media.com (8.11.6/8.11.6) id g2839WI12831; Thu, 7 Mar 2002 22:09:32 -0500 (EST) (envelope-from mike) Date: Thu, 7 Mar 2002 22:09:32 -0500 From: Mike Barcroft To: Garance A Drosihn Cc: "Andrey A. Chernov" , current@FreeBSD.ORG Subject: Re: fix is incomplete Message-ID: <20020307220932.G81803@espresso.q9media.com> References: <20020307182504.GA20764@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ; from drosih@rpi.edu on Thu, Mar 07, 2002 at 05:28:54PM -0500 Organization: The FreeBSD Project Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Garance A Drosihn writes: > At 9:25 PM +0300 3/7/02, Andrey A. Chernov wrote: > > fix is incomplete because 'u_int32_t' is not defined > >(but must be) for standalone . Please add some includes > >for u_int32_t definition too, probably Perhaps subconsciously I was trying to keep making software include before . :) I just committed a fix. > As a minor side question, should we also have that defined as > uint32_t instead of u_int32_t ? Yes, usually. I just grabbed the copy from , which wasn't correct. uint32_t is more correct, but requires pollution from another header, so I used the __uint32_t variant. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message