Date: Mon, 24 Jul 2017 23:28:17 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220983] www/node is incorrectly patching common.gypi Message-ID: <bug-220983-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220983 Bug ID: 220983 Summary: www/node is incorrectly patching common.gypi Product: Ports & Packages Version: Latest Hardware: amd64 OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: bhughes@freebsd.org Reporter: randy+bsd@terbush.org Flags: maintainer-feedback?(bhughes@freebsd.org) Assignee: bhughes@freebsd.org The ports install for www/node is patching common.gypi which includes the following lines. ``` ['OS=3D=3D"freebsd"', { # Use this flag because on FreeBSD std::pairs copy constructor is non-trivial # https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html 'cflags': [ '-D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=3D1' ], 'ldflags': [ '-Wl,--export-dynamic', ], ``` Setting _LIBCPP_TRIVIAL_PAIR_COPY_CTOR=3D1 on FreeBSD 11 systems compling w= ith clang will cause compile of node modules to fail with the following error: ``` gmake: Entering directory '/home/randy/Develop/tkg/node_modules/sharp/build' TOUCH Release/obj.target/libvips-cpp.stamp CXX(target) Release/obj.target/sharp/src/common.o In file included from ../src/common.cc:15: In file included from /usr/include/c++/v1/cstdlib:85: /usr/include/c++/v1/__config:73:2: error: "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" = is no longer supported. use _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR instead #error "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported. \ ^ 1 error generated. gmake: *** [sharp.target.mk:151: Release/obj.target/sharp/src/common.o] Err= or 1 gmake: Leaving directory '/home/randy/Develop/tkg/node_modules/sharp/build' gyp ERR! build error=20 gyp ERR! stack Error: `gmake` failed with exit code: 2 ``` The patch in files/patch-common.gypi needs to be removed at least for newer versions of FreeBSD. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220983-13>