From owner-freebsd-testing@FreeBSD.ORG Sat Apr 5 17:06:34 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D64537AD; Sat, 5 Apr 2014 17:06:34 +0000 (UTC) Received: from mail-pb0-x233.google.com (mail-pb0-x233.google.com [IPv6:2607:f8b0:400e:c01::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A263C7E6; Sat, 5 Apr 2014 17:06:34 +0000 (UTC) Received: by mail-pb0-f51.google.com with SMTP id uo5so4863645pbc.10 for ; Sat, 05 Apr 2014 10:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=w3a8+Ss7FzGRwct9Jz8HIA6HjhEoVDdADp/WhgjzOuw=; b=LYZqI+lzMqj9Dw9RfH3tIYuE9Gh5mwXdoiVNlgdM6IpjZwWNL74d6OqETC6VH9Wp9m pjMVJ8oPBi+8GtyYf0Bsetn834xY/aUJSyrSucrMV+vGVaPfYD60bgEE0Q7IpzqF4ofE VfX/aRruowVa3FSQKhADVH4Rc4BtUTQ7Cp5wTvUED4gC5PpKIonB4JULGFiGLVYx2ynm MsfBDgqdKXMa/QYl1GkRmsKqJ4/JifUAE/7qFIpOn21RvzeTFsuxfahxHuozZTs+B1Rg fXAPDf9iomkKqt6pU8grcB/KAw7MZMU2awmzLk5usXDl0QQ9TqWPEK/O8f4W6ofc8R7i ar4g== X-Received: by 10.66.232.40 with SMTP id tl8mr3399pac.137.1396717594221; Sat, 05 Apr 2014 10:06:34 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:594:7736:96fd:de7e? ([2601:8:ab80:7d6:594:7736:96fd:de7e]) by mx.google.com with ESMTPSA id pv4sm25465400pbb.55.2014.04.05.10.06.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 05 Apr 2014 10:06:33 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: ATF work From: Garrett Cooper In-Reply-To: Date: Sat, 5 Apr 2014 10:06:30 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <74A4FAAB-88B8-4226-949A-11AA8D99D662@gmail.com> References: <20140402085349.GA61802@x2.osted.lan> To: Craig Rodrigues X-Mailer: Apple Mail (2.1874) Cc: "freebsd-testing@freebsd.org" , Peter Holm X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Apr 2014 17:06:35 -0000 On Apr 2, 2014, at 11:47 AM, Garrett Cooper = wrote: > On Wed, Apr 2, 2014 at 10:21 AM, Craig Rodrigues = wrote: >> On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers = wrote: >>> On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm wrote: >>>> I have uploaded a snapshot of the ATF work done for EMC Isilon, >>>> based primarily on Garrett Cooper's work. >>>>=20 >>>> = http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz >>>> + >>>> chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr >>>=20 >>> Holy patch queue, Batman! There's fifty thousand lines of code in = here! >>=20 >>=20 >> When a patch is that big, it becomes very difficult to review. >>=20 >> You might want to consider forking a copy on github of the >> https://github.com/freebsd/freebsd repository and maintaining the = patch there >> until it is MFC'd: >>=20 >> https://help.github.com/articles/fork-a-repo >> https://help.github.com/articles/syncing-a-fork >>=20 >> It's not perfect but some of the web interface tools around the = github >> ecosystem make reviewing patches (and contributing updates) a bit = easier. >=20 > I was going to move master aside and make all of the ATF work into its > own separate branch again as my fork's master still contains little > tidbits of other fixes and hacks that I made to make things work on my > system(s). When I originally did this on my fork I was dealing with a > lot more branches (nowadays I mostly maintain my fork instead of > develop/port new code). I=92ve master on my fork reflects FreeBSD master. =93atf=94 now = reflects all of my ATF work, so if you diff master and atf you=92ll see = the relevant changes I=92ve done for ATF in the past. I=92ll update the = docs on the wiki to reflect this. Thanks! -Garrett=