From owner-freebsd-bugs@FreeBSD.ORG Sat Aug 16 09:50:26 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6328C37B42F for ; Sat, 16 Aug 2003 09:50:22 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D9F6643F75 for ; Sat, 16 Aug 2003 09:50:14 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7GGoEUp098725 for ; Sat, 16 Aug 2003 09:50:14 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7GGoEkg098724; Sat, 16 Aug 2003 09:50:14 -0700 (PDT) Date: Sat, 16 Aug 2003 09:50:14 -0700 (PDT) Message-Id: <200308161650.h7GGoEkg098724@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Eugene Grosbein Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Eugene Grosbein List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Aug 2003 16:50:28 -0000 The following reply was made to PR bin/55346; it has been noted by GNATS. From: Eugene Grosbein To: Doug White Cc: stable@freebsd.org, bug-followup@freebsd.org Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely Date: Sun, 17 Aug 2003 00:46:19 +0800 On Fri, Aug 15, 2003 at 07:13:57PM -0700, Doug White wrote: > You should not remove the ifdef and change the indentation of deljob. Just > s/del/free and be done with it :-) I highly doubt anyone needs to disable > job control in sh, but in the off chance they do, you might as well keep > the ifdef around. > > Note that freejob calls deljob. That's why I've removed #ifdef. freejob() already has these #ifdefs around deljob(). However, freejob() is not wrapped with #ifdefs itself. So I've removed them here. Identation is my fault. Eugene Grosbein